Skip to content

Conversation

@mokagio
Copy link
Contributor

@mokagio mokagio commented Nov 21, 2025

Inconsequential nit I noticed while investigating https://linear.app/a8c/issue/AINFRA-852

@dangermattic
Copy link
Collaborator

dangermattic commented Nov 21, 2025

1 Warning
⚠️ Modules/Package.swift was changed without updating its corresponding Package.resolved.

If the change includes adding, removing, or editing a dependency please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running swift package resolve).

If the change to the Package.swift did not modify dependencies, ignoring this warning should be safe, but we recommend double checking and running the package resolution just in case.
.

Generated by 🚫 Danger

@sonarqubecloud
Copy link

@mokagio mokagio added the Tooling Build, Release, and Validation Tools label Nov 21, 2025
@mokagio mokagio added this to the 26.6 milestone Nov 21, 2025
@mokagio mokagio enabled auto-merge November 21, 2025 06:17
@mokagio mokagio requested review from crazytonyli and kean and removed request for crazytonyli November 21, 2025 06:17
@wpmobilebot
Copy link
Contributor

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number29854
VersionPR #25004
Bundle IDorg.wordpress.alpha
Commit7a33180
Installation URL4g0e4vh9s2ds0
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number29854
VersionPR #25004
Bundle IDcom.jetpack.alpha
Commit7a33180
Installation URL5q5rdd88rha1o
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

Copilot finished reviewing on behalf of mokagio November 21, 2025 06:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects the placement of a comment in the Package.swift file. The comment explaining that only tags (not branches or commits) can be used for the wordpress-rs package was previously positioned above the GutenbergKit package declaration, and has now been moved to directly precede the wordpress-rs package declaration where it belongs.

  • Relocates a comment about wordpress-rs package constraints to appear immediately above the relevant package declaration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mokagio mokagio added this pull request to the merge queue Nov 21, 2025
Merged via the queue into trunk with commit 79b9d30 Nov 21, 2025
38 of 40 checks passed
@mokagio mokagio deleted the mokagio/fix-comment-location branch November 21, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tooling Build, Release, and Validation Tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants