This repository was archived by the owner on Jan 24, 2025. It is now read-only.
Update JWT to accept member ID #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n0mid
suggested changes
Nov 12, 2021
server/index.js
Outdated
| jti: nanoid(), | ||
| origin: WK_CUSTOM_VENDOR_ORIGIN || undefined | ||
| }, | ||
| process.env.WK_JWT_PRIVATE_KEY, |
Contributor
There was a problem hiding this comment.
You can extract this value with another env variables:
Suggested change
| process.env.WK_JWT_PRIVATE_KEY, | |
| WK_JWT_PRIVATE_KEY, |
server/index.js
Outdated
| process.env.WK_JWT_PRIVATE_KEY, | ||
| {algorithm: 'RS256'} | ||
| ); | ||
| const {WK_API_KEY, WK_CUSTOMER_ID, WK_USER_ID, WK_CUSTOM_VENDOR_ORIGIN} = process.env; |
Contributor
There was a problem hiding this comment.
Suggested change
| const {WK_API_KEY, WK_CUSTOMER_ID, WK_USER_ID, WK_CUSTOM_VENDOR_ORIGIN} = process.env; | |
| const {WK_API_KEY, WK_CUSTOMER_ID, WK_USER_ID, WK_CUSTOM_VENDOR_ORIGIN, WK_JWT_PRIVATE_KEY} = process.env; |
server/index.js
Outdated
| { | ||
| sub: subParams.join(':'), | ||
| jti: nanoid(), | ||
| origin: WK_CUSTOM_VENDOR_ORIGIN || undefined |
Contributor
There was a problem hiding this comment.
If WK_CUSTOM_VENDOR_ORIGIN is not defined it will be undefined.
Suggested change
| origin: WK_CUSTOM_VENDOR_ORIGIN || undefined | |
| origin: WK_CUSTOM_VENDOR_ORIGIN |
n0mid
approved these changes
Nov 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Dima, testing out the ability to add member of the team into the JWT for this issue: https://github.com/workato/issues/issues/19744. Can you help to verify if something like this will work? Thanks.