fix: link ucrt on Windows MSVC for libc FFI symbols - #23
Merged
Merged
Conversation
Add #[link(name = "ucrt")] to extern blocks declaring C runtime functions on Windows MSVC. Without this, the linker cannot resolve gmtime_s, localtime_s, fprintf, and fscanf when building release binaries for x86_64-pc-windows-msvc. The main extern block uses cfg_attr to only apply the link attribute on MSVC targets. Windows-specific blocks (iob_func, popen/pclose, localtime_s/gmtime_s) use #[link] directly since they are already gated behind #[cfg(target_os = "windows")]. Closes #21
danielsreichenbach
force-pushed
the
fix/windows-msvc-linking
branch
from
February 20, 2026 05:37
7840b9b to
df96c8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#[link(name = "ucrt")]to extern blocks declaring C runtime functions on Windows MSVCgmtime_s,localtime_s,fprintf,fscanfCloses #21
Test plan
x86_64-pc-windows-msvcon next tag