feat(basic-memory): persistent knowledge base integration with research-informed operations#4
Closed
wpfleger96 wants to merge 2 commits intomainfrom
Closed
feat(basic-memory): persistent knowledge base integration with research-informed operations#4wpfleger96 wants to merge 2 commits intomainfrom
wpfleger96 wants to merge 2 commits intomainfrom
Conversation
d4644c6 to
2406651
Compare
… KB operations The basic-memory MCP integration was partially implemented but non-functional: mcps.json was empty (so _is_basic_memory_configured always returned False), the PostToolUse hook was never wired, git ops in the runner script blocked MCP startup, and the upgrade loop ignored is_enabled. This fixes all of that and adds operational patterns from Karpathy's llm-wiki and Block's world model (ADR-182) research. Infrastructure: add MCP definition to personal/work profile mcp_overrides, fix git-init-before-config ordering in setup.sh, remove dangerous --force push fallback, background git ops in runner.sh, gate status/upgrade on profile config, call setup on upgrade path, add PostToolUse hook to settings.json. Operations: add GAP annotations, [misconception] tags, write-back loop guidance, eval-first methodology, and KB lint health-check to /kb skill. Tests: 10 new tests covering _is_basic_memory_configured, ensure_basic_ memory_installed, and is_enabled filtering in upgrade loop.
00512e4 to
898eeb3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integrates basic-memory as a persistent, git-synced markdown knowledge base for AI coding agents. Knowledge persists across sessions, repos, and machines via git sync, and is browsable in Obsidian.
This PR has two layers:
Infrastructure — wires basic-memory into the
ai-rulesCLI and profile system:personalandworkprofilemcp_overrides(notdefault)PostToolUsehook auto-commits and pushes after basic-memory write operationsgit init, GitHub remote creation, and directory scaffoldingToolSpecwithis_enabledgating soupgradeskips basic-memory for profiles that don't use itversion,install,status, andupgradeall surface basic-memoryOperations — the
/kbskill encodes proven patterns from Karpathy's llm-wiki, Block's world model ADR-182, and production case studies:[GAP: ...]) — mark uncertain/unverified claims so agents surface uncertainty rather than hiding it (fromsquareup/world)[misconception]) — document what is NOT true to prevent confident false assertions (fromsquareup/world"Counterfactual Warnings")[promote]tag flags patterns worth distilling intoAGENTS.mdrulesFiles changed
Profiles —
personal.yaml,work.yamlget basic-memorymcp_overridesHooks —
basic-memory-runner.sh(background git sync),basic-memory-setup.sh(init order fix, remove--force),basic-memory-post-write.sh(unchanged, wired viasettings.json)CLI —
cli.pygatesstatuson config, respectsis_enabledin upgrade loopInstaller —
installer.pycalls setup on upgrade, surfaces output on first installConfig —
settings.jsonaddsPostToolUsehook entrySkill —
SKILL.mdadds GAP, misconception, write-back, eval-first, lint sections;note-templates.mdadds misconception templateDocs —
config/AGENTS.mdexpanded basic-memory section; repoAGENTS.mdaddskbto skill listTests — 10 new tests for
_is_basic_memory_configured,ensure_basic_memory_installed,is_enabledfiltering