[fieldImages] refactor: FTC field and proper naming #8034
+306
−222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes wpilibsuite#8018 - Adds the 2024-2025 FTC field image & json * probably needs its dimensions readjusted, but I've never done FTC so idk how it should look like - used a better naming scheme of `<year> F{R,T}C <gamename>` - same for the pngs n such It compiles, but I never got the chance to test because I'm having trouble with gradle and just need to get something out there. TODOs: - [ ] improve file naming/structure - [ ] actually test Signed-off-by: crueter <[email protected]>
|
I just realized this may need a similar refactor on the AprilTag side. I'll wait until I can get FRC/FTC namespacing sorted to get onto that. |
Signed-off-by: crueter <[email protected]>
Signed-off-by: crueter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8018
idk how it should look like
<year> F{R,T}C <gamename>It compiles, but I never got the chance to test because I'm having
trouble with gradle and just need to get something out there.
TODOs:
Signed-off-by: crueter [email protected]