feat: add batch withdraw support to stealth sender - #145
Open
pharwasz wants to merge 6 commits into
Open
Conversation
|
@pharwasz Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…uturenet (wraith-protocol#139) Adds stellar/scripts/deploy-dryrun.sh - self-contained script that deploys all four Wraith contracts to futurenet, wires them, runs smoke tests, and prints IDs with stellar.expert links. Idempotent via deterministic deploy salts. Includes DEPLOYMENT.md docs and CI nightly schedule job. Co-authored-by: Alaps <qozeemibrahim065@gmail.com>
…otocol#140) Add a cargo-bench harness that compares N stealth-sender::send calls against one stealth-batch-sender::batch_send for N in {1,2,5,10,15,20}, records instruction gas and wall-clock, and documents the N=1 crossover in PERF.md. Closes 121 Co-authored-by: Cursor <cursoragent@cursor.com>
…ith-protocol#141) Add rotate_signers flow to stealth-sender and wraith-names (the two Timelock + Multisig Upgradable contracts per GOVERNANCE.md), gated by quorum approval from current signers plus a 7-day timelock matching the existing upgrade timelock. Invalid thresholds (zero, or greater than the proposed signer count) are rejected with a dedicated error. Execution emits SignersRotated; cancellation fully clears pending proposal state so a new rotation can be proposed immediately. Update MULTISIG.md with the on-chain rotation runbook. Futurenet rehearsal is called out as a follow-up since it requires a live deployment. Closes wraith-protocol#104 Co-authored-by: OpadijoIdris <Opadijoayomipo@gmail.com>
…h-protocol#144) Co-authored-by: boshadowwolf-ai <boshadowwolf@gmail.com>
pharwasz
force-pushed
the
feat/withdraw-many-batch
branch
from
July 27, 2026 14:46
d03bca6 to
1b2169a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds batch withdrawal support to the
stealth-sendercontract by introducing a newwithdraw_manyentrypoint. The implementation enables multiple withdrawals to be processed atomically in a single transaction while enforcing a maximum batch size and emitting both per-withdrawal and aggregate events.Changes
Added
withdraw_manyto thestealth-sendercontract.Enforced a maximum batch size of 30 withdrawals.
Leveraged Soroban transaction atomicity so any failed withdrawal reverts the entire batch.
Emitted
Withdrawnevents for each successful withdrawal and aBatchWithdrawnevent for the overall operation.Added integration tests covering:
Updated performance documentation with benchmark results for 1, 10, and 30 entry batches.
Updated snapshots to reflect the new functionality.
Testing
If your repository uses GitHub's issue-closing keywords, append this to the bottom:
Closes #120