feat(i18n): full i18n coverage for Stellar flows (#112)#133
Open
Samuelaladesiun3334 wants to merge 2 commits into
Open
feat(i18n): full i18n coverage for Stellar flows (#112)#133Samuelaladesiun3334 wants to merge 2 commits into
Samuelaladesiun3334 wants to merge 2 commits into
Conversation
- Extract all hardcoded strings from Stellar flow components to i18n keys - Add EN, ES, PT, FR translation files (stellar send/receive/history/vault/wallet-picker) - Expand LocaleSwitcher to include PT and FR options - Register PT and FR locales in i18n/index.ts - Update StellarSend, StellarSendView, StellarReceive, StellarReceiveView, StellarHistory, StellarVault, StellarVaultClaim, StellarVaultDeposit, StellarMatchCard, StellarWalletPicker, StellarWalletButton to use t() - Add scripts/check-i18n.js: validates all locales have every EN key - Add CI job i18n-check that runs the script and blocks merge on missing keys
|
@samuelaladesiun is attempting to deploy a commit to the truthixify's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Samuelaladesiun3334 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
|
- scripts/check-i18n.js: wrap long console.warn template literal - StellarVaultClaim.tsx: wrap long t() call with object arg - StellarWalletButton.tsx: reorder Tailwind classes so lines stay under printWidth, break connectedVia label onto its own line - StellarWalletPicker.tsx: break walletPickerTitle and scanWithWalletConnect h2 onto their own lines, split isAvail inline comment to separate line
Author
|
Am really sorry for delay in reply |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed #112 - Extract all hardcoded strings from Stellar flow components to i18n keys
Add EN, ES, PT, FR translation files (stellar send/receive/history/vault/wallet-picker)
Expand LocaleSwitcher to include PT and FR options
Register PT and FR locales in i18n/index.ts
Update StellarSend, StellarSendView, StellarReceive, StellarReceiveView,
StellarHistory, StellarVault, StellarVaultClaim, StellarVaultDeposit,
StellarMatchCard, StellarWalletPicker, StellarWalletButton to use t()
Add scripts/check-i18n.js: validates all locales have every EN key
Add CI job i18n-check that runs the script and blocks merge on missing keys