Skip to content

Remove inaccurate error message regarding ghg_input #2199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release-v4.7.0
Choose a base branch
from

Conversation

kkeene44
Copy link
Collaborator

TYPE: bug fix

KEYWORDS: ghg_input, idealized, no radiation

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
Most idealized cases have radiation options turned off, which causes the following error message to inaccurately print to the rsl files when ideal.exe is run:

ERROR: ghg_input available only for these radiation schemes: CAM, RRTM, RRTMG, RRTMG_fast
And the LW and SW schemes must be reasonably paired together:
OK = CAM LW with CAM SW
OK = RRTM, RRTMG LW or SW, RRTMG_fast LW or SW may be mixed

Solution:
In share/module_check_a_mundo.F, add code to ensure that when radiation is turned off, not only does the message not print, but the namelist value for ghg_input is set to 0, as well.

LIST OF MODIFIED FILES:
M share/module_check_a_mundo.F

TESTS CONDUCTED:

  1. Code compiles okay and no longer prints the message for idealized cases (tested with em_quarter_ss).
  2. Are the Jenkins tests all passing?

@kkeene44 kkeene44 requested review from a team as code owners April 14, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant