-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show other websites for meetups #2242
base: main
Are you sure you want to change the base?
Conversation
@@ -35,6 +35,13 @@ | |||
</div> | |||
{% endif %} | |||
|
|||
{# Other internet presence #} | |||
{% if meetup['website'] %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder about doing this with links
and allowing multiple?
Something like:
- links:
- Meetup: https://meetup...
- LinkedIn: https://linked..
That way you can control the link copy and allow multiple if needed?
{% if meetup['website'] %} | ||
<div> | ||
Elsewhere: <a href="{{ meetup['website']}}">{{ meetup['website'] }}</a> | ||
</div> | ||
{% endif %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{% if meetup['website'] %} | |
<div> | |
Elsewhere: <a href="{{ meetup['website']}}">{{ meetup['website'] }}</a> | |
</div> | |
{% endif %} | |
{% if meetup['links'} %} | |
<ul> | |
{% for text, link in meetup['links'].items() %} | |
<li> | |
<a href="{{ link }]">{{ text }}</a> | |
</li> | |
{% endfor %} | |
</ul> | |
{% endif %} |
@ericholscher and @plaindocs could we potentially change how we frame it away from Meetups and list them as Community links and allow multiple links? |
Yep, I've got two half assed fixes to this, I'll clean one up so we can put it in and forget about it. |
@rosewms this is the zero effort approach:
website
key from all meetups (we weren't using it)website
key if it exists asElsewhere
:website: cool-linked-in-url
hereCaveats:
Let me know if this isn't enough, and I'll tweak further.
📚 Documentation preview 📚: https://writethedocs-www--2242.org.readthedocs.build/