Skip to content

Update tests for CapturesVisitor #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Update tests for CapturesVisitor #1

wants to merge 2 commits into from

Conversation

wrzian
Copy link
Owner

@wrzian wrzian commented Nov 30, 2024

The test didn't capture the foo variable because it wasn't defined, but I believe the intention was to have a capturable call here.

@wrzian
Copy link
Owner Author

wrzian commented Dec 2, 2024

I actually kept working on this and added more tests :)

lmk if the changes to CapturesVisitor aren't that helpful. I like that this makes it more explicit how undefined variables are treated, but I'm not sure its the best change

@wrzian wrzian changed the title Fix captures test in typst-eval/call.rs Update tests for CapturesVisitor Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant