Update Grafana dashboard path and Prometheus targets for observability - #3346
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe gateway observability configuration now loads Grafana’s home dashboard from the mounted dashboards directory and scrapes Policy Engine and Router metrics from the ChangesGateway observability
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change restores observability targets and points Grafana to the mounted dashboards directory; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description covers the purpose, goals, approach, documentation, testing, security checks, and test environment. It omits User stories, Samples, and Related PRs, and it describes the Grafana path as a directory although the implementation uses a specific JSON file. Full details: Linked Issues checkExplanation The PR satisfies issue Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Purpose
Prometheus scrapes
policy-engineandrouter, which no longer exist as services. They were merged intogateway-runtime. Policy Engine and Router metrics are never collected, and the dashboards silently stay empty. Also fixes the issue Grafana's home dashboard pointed at a directory containing no dashboards, so it opened on a blank page.Resolves #3343
Goals
Restore Policy Engine and Router metrics, and make Grafana open on the Infrastructure Overview dashboard.
Approach
policy-engineandrouterscrape jobs atgateway-runtime. Job names unchanged, so existing dashboards and alerts are unaffected.GF_DASHBOARDS_DEFAULT_HOME_DASHBOARD_PATHat/etc/grafana/dashboards/, where the dashboards are mounted.5 lines across 4 files.
Documentation
N/A — corrections to existing internal values, no documented behaviour changes.
Automation tests
N/A — configuration-only change. Verified manually: Prometheus reports the corrected scrape URLs, and Grafana's home dashboard path now resolves to an existing file.
Security checks
Test environment
macOS (Apple Silicon), Rancher Desktop, Docker Compose v2.