Update mcp-auth and mcp-authz policy versions - #3458
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe gateway updates MCP policy versions and adds integration coverage for ChangesMCP gateway URL configuration
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to The configured gateway URL behavior has no established merge-blocking risk in the available evidence. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description explains the dependency updates and references the related issue, but it omits most required template sections, including Approach, User stories, Documentation, Automation tests, Security checks, Samples, Related PRs, and Test environment. Resolution Complete the required sections in the repository template. Describe the implementation approach, affected user stories, documentation impact, unit and integration test coverage, security checks, samples, related pull requests, and test environment. Mark non-applicable sections with N/A and a brief explanation.
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Git: CodeRabbit could not clone the repository, so clone-backed analysis was skipped and this review may be incomplete. Verify repository clone access, such as SSH credentials, before requesting another full review. If clone access is intentionally unavailable, use Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
| @@ -84,7 +84,7 @@ Feature: Test how MCP Proxies behave when various policies are applied. | |||
|
|
|||
| When I use the MCP Client to send an initialize request to "http://127.0.0.1:8080/mcpauth/mcp" | |||
| Then the response status code should be 401 | |||
| And the response header "WWW-Authenticate" should contain "http://localhost:8080/mcpauth/.well-known/oauth-protected-resource" | |||
| And the response header "WWW-Authenticate" should contain "https://mcp-e2e-gatewayurl.example.com:7777/mcpauth/.well-known/oauth-protected-resource" | |||
There was a problem hiding this comment.
We cannot ignore the default scenario. We have to validate both scenarios through tests
There was a problem hiding this comment.
Since it is a system parameter, in order to do that we have to bring another test stack with a different config.toml. Not sure whether it is worth doing just to check this behavior only.
Also this is covered in the policy's unit tests.
This pull request updates the versions of two policy dependencies in the
gateway/build-manifest.yamlfile. These updates ensure that the project uses the latest features and fixes from the upstream policy modules.Dependency updates:
mcp-authpolicy from versionv1.2.1tov1.3.0.mcp-authzpolicy from versionv1.1.1tov1.2.0.