Optimize UUID Generation: Replace SecureRandom with ThreadLocalRandom for Non-Blocking Performance #4269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to improve the performance of UUID generation by using
ThreadLocalRandominstead ofUUID.randomUUID(). The changes are applied to two classes:CacheEntryInfoandRequestCorrelationIdValve.Improvements to UUID generation:
core/javax.cache/src/main/java/javax/cache/CacheEntryInfo.java: ReplacedUUID.randomUUID().toString()with a new methodgenerateFastUUID()that usesThreadLocalRandomfor faster UUID generation.core/javax.cache/src/main/java/javax/cache/CacheEntryInfo.java: Added thegenerateFastUUID()method to generate UUIDs usingThreadLocalRandom.core/org.wso2.carbon.tomcat.ext/src/main/java/org/wso2/carbon/tomcat/ext/valves/RequestCorrelationIdValve.java: ReplacedUUID.randomUUID().toString()with a new methodgenerateFastUUID()that usesThreadLocalRandomfor faster UUID generation.core/org.wso2.carbon.tomcat.ext/src/main/java/org/wso2/carbon/tomcat/ext/valves/RequestCorrelationIdValve.java: Added thegenerateFastUUID()method to generate UUIDs usingThreadLocalRandom.core/org.wso2.carbon.tomcat.ext/src/main/java/org/wso2/carbon/tomcat/ext/valves/RequestCorrelationIdValve.java: ImportedThreadLocalRandomfor use in the new UUID generation method.