-
Notifications
You must be signed in to change notification settings - Fork 123
Update authorize Bitbucket with Choreo documentation #1877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: PE
Are you sure you want to change the base?
Conversation
WalkthroughDocumentation updates standardize credential terminology (use "Credential"/"API token" instead of "Personal Access Token"/"PAT"), rename "Account" to "Workspace", add a "User" permission row, and extend Bitbucket permission tables with a Delete column and updated Read/Write/Delete semantics for Workspace, User, Repositories, Pull Requests, and Webhooks. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (2)
en/pe-docs/docs/infrastructure/credentials/set-up-git-provider-authentication-for-choreo-deployments.md (1)
12-12: Clarify generic credential instruction for different Git providers.Line 12 states users should connect Bitbucket and GitLab repositories using a "Personal Access Token (PAT)," but the Bitbucket section now specifies API tokens. Consider clarifying that different providers use different token types (Bitbucket now requires API tokens, GitLab uses PAT).
Example revision:
-You can connect Bitbucket, Gitlab repositories to choreo organization using a Personal Access Token(PAT). For github, the developers can install [WSO2 Cloud App](https://github.com/marketplace/choreo-apps) during component creation and get necessary permissions via Github itself. +You can connect Bitbucket and GitLab repositories to your Choreo organization using credential tokens (API tokens for Bitbucket, personal access tokens for GitLab). For GitHub, developers can install the [WSO2 Cloud App](https://github.com/marketplace/choreo-apps) during component creation to grant necessary permissions.en/developer-docs/docs/develop-components/develop-components-with-git.md (1)
22-22: Clarify generic credential instruction for different Git providers.Line 22 instructs users to enter a "Personal Access Token" generically for all providers, but the Bitbucket section specifies API tokens. Consider clarifying that different providers use different token types (Bitbucket now requires API tokens, GitLab uses PAT).
Example revision:
-6. Enter a **Credential Name**, select the Git provider, and enter the **Personal Access Token** you obtained from the Git provider. +6. Enter a **Credential Name**, select the Git provider, and enter the credential token (API token for Bitbucket, personal access token for GitLab) you obtained from the Git provider.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
en/developer-docs/docs/develop-components/develop-components-with-git.md(1 hunks)en/pe-docs/docs/infrastructure/credentials/set-up-git-provider-authentication-for-choreo-deployments.md(1 hunks)
🔇 Additional comments (2)
en/pe-docs/docs/infrastructure/credentials/set-up-git-provider-authentication-for-choreo-deployments.md (1)
36-44: Content update is accurate and consistent with Bitbucket API token requirements.The permissions table correctly reflects the API token-based authentication model. The addition of the Delete column for Webhooks aligns with the new scopes available in Bitbucket API tokens.
en/developer-docs/docs/develop-components/develop-components-with-git.md (1)
91-99: Content update is accurate and consistent with Bitbucket API token requirements.The permissions table correctly reflects the API token-based authentication model. The addition of the Delete column for Webhooks aligns with the new scopes available in Bitbucket API tokens. The changes are identical and consistent with the PE documentation file.
en/developer-docs/docs/develop-components/develop-components-with-git.md
Outdated
Show resolved
Hide resolved
...docs/infrastructure/credentials/set-up-git-provider-authentication-for-choreo-deployments.md
Outdated
Show resolved
Hide resolved
en/developer-docs/docs/develop-components/develop-components-with-git.md
Outdated
Show resolved
Hide resolved
...docs/infrastructure/credentials/set-up-git-provider-authentication-for-choreo-deployments.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
en/developer-docs/docs/develop-components/develop-components-with-git.md(2 hunks)en/pe-docs/docs/infrastructure/credentials/set-up-git-provider-authentication-for-choreo-deployments.md(2 hunks)
🧰 Additional context used
🪛 LanguageTool
en/pe-docs/docs/infrastructure/credentials/set-up-git-provider-authentication-for-choreo-deployments.md
[uncategorized] ~12-~12: The official name of this software platform is spelled with a capital “H”.
Context: ...Personal access tokens for GitLab). For github, the developers can install [WSO2 Clou...
(GITHUB)
[uncategorized] ~12-~12: The official name of this software platform is spelled with a capital “H”.
Context: ...ation and get necessary permissions via Github itself. 1. Sign in to the [Choreo Cons...
(GITHUB)
🔇 Additional comments (4)
en/developer-docs/docs/develop-components/develop-components-with-git.md (2)
22-22: ✓ Approved: Terminology update from "Personal Access Token" to "Credential"The updated terminology is clearer and aligns with the Choreo UI conventions. This change provides better consistency across the documentation.
91-99: ✓ Approved: Bitbucket permissions table with API token terminology and Delete columnThe table structure is correct, includes the previously-flagged grammar fix ("an API token"), and reflects the updated permission model with Workspace, User, and Delete semantics. The permissions align with Bitbucket's current API token capabilities.
en/pe-docs/docs/infrastructure/credentials/set-up-git-provider-authentication-for-choreo-deployments.md (2)
17-18: ✓ Approved: Credential terminology and flow stepsThe updated terminology ("Credential Name", "Credential Token") is clearer than the prior wording. Combined with the context provided in line 12, users can now distinguish between different credential types (API tokens vs. Personal access tokens) across Git providers.
36-44: ✓ Approved: Bitbucket permissions table consistent with developer documentationThe permission table correctly reflects the updated API token model with the Delete column and new entities (Workspace, User). Permissions are consistently defined across both documentation files.
Description
Type of change
Testing
Related issues
Summary by CodeRabbit