-
Notifications
You must be signed in to change notification settings - Fork 363
Fix: Update OAuth2/OpenID Connect additional query parameters documentation for versions 5.10.0 and 5.11.0 (Product IS issue #23634) #5696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…tation for versions 5.10.0 and 5.11.0 (product-is#23634)
- Enhanced Additional Query Parameters section with clear categorization
- Added three types of query parameters: Fixed, Dynamic from request, and Dynamic from adaptive scripts
- Included concrete examples for domain=${fidp} format
- Added sample adaptive authentication script showing authenticatorParams usage
- Properly escaped dollar signs to prevent math rendering issues
- Aligned documentation with capabilities introduced in 5.10.0 WUM pack
|
wso2-engineering-bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
WalkthroughThe PR restructures documentation for OAuth2/OpenID Connect "Additional Query Parameters" across two version branches, converting inline parameterized explanations into structured three-part guides with explicit examples and adaptive authentication script samples. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🧰 Additional context used🪛 GitHub Actions: Markdown Linten/identity-server/5.10.0/docs/learn/configuring-oauth2-openid-connect.md[error] 18-18: markdownlint: MD030/list-marker-space Spaces after list markers. markdownlint-cli2-action@v20 failed on this file. 🪛 LanguageToolen/identity-server/5.10.0/docs/learn/configuring-oauth2-openid-connect.md[uncategorized] ~155-~155: Loose punctuation mark. Multiple para... (UNLIKELY_OPENING_PUNCTUATION) en/identity-server/5.11.0/docs/learn/configuring-oauth2-openid-connect.md[uncategorized] ~150-~150: Loose punctuation mark. Multiple para... (UNLIKELY_OPENING_PUNCTUATION) ⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This PR was automatically generated by Claude AI.
Issue
Changes Made
Enhanced the "Additional Query Parameters" section in the OAuth2/OpenID Connect configuration documentation with:
Clear categorization of three types of query parameters:
Concrete examples including:
[email protected]login_hint=${paramName}ordomain=${fidp}login_hint=$authparam{userIdentifier}Sample adaptive authentication script demonstrating the
authenticatorParamsusage mentioned in the original issueSample OIDC request showing how parameters are passed in the request URL
Proper HTML entity escaping for dollar signs to prevent math rendering issues with the arithmatex extension
Affected Versions
Note: Versions 7.0.0, 7.1.0, 7.2.0, and next already have comprehensive documentation for this feature via shared includes and do not require updates.
Style Scope Verification
Microsoft Style Guidelines have been applied ONLY to newly added content without modifying existing content style unless specifically requested.
Verification
mkdocs buildpassed successfully for version 5.11.0$in the output🤖 Generated with Claude Code
Co-Authored-By: Claude [email protected]
Summary by CodeRabbit