-
Notifications
You must be signed in to change notification settings - Fork 363
Update Managed In User Store related docs #5707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update Managed In User Store related docs #5707
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the WalkthroughDocumentation update expanding the attribute management guide with a new "Manage in User Store" subsection that replaces a single-line instruction with comprehensive explanations of attribute storage behavior, visual aids, and a warning about potential accessibility issues when changing storage locations. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (4)
en/asgardeo/docs/assets/img/guides/organization/attributes/configure-attribute-exclude-user-store.pngis excluded by!**/*.pngen/asgardeo/docs/assets/img/guides/organization/attributes/configure-attribute-managed-in-user-store.pngis excluded by!**/*.pngen/identity-server/next/docs/assets/img/guides/organization/attributes/configure-attribute-excluded-user-store.pngis excluded by!**/*.pngen/identity-server/next/docs/assets/img/guides/organization/attributes/configure-attribute-managed-in-user-store.pngis excluded by!**/*.png
📒 Files selected for processing (1)
en/includes/guides/users/attributes/manage-attributes.md(1 hunks)
🔇 Additional comments (1)
en/includes/guides/users/attributes/manage-attributes.md (1)
380-403: Well-structured new section with comprehensive guidance.The new "Manage in User Store" section is clear, well-organized, and appropriately detailed. The explanation of checked/unchecked behavior, integration with Attribute Mappings, and the accessibility warning are all valuable additions. The visual aids should help users understand the selective management capability.
Please verify that the referenced images exist at the specified paths:
{{base_path}}/assets/img/guides/organization/attributes/configure-attribute-managed-in-user-store.png(line 384){{base_path}}/assets/img/guides/organization/attributes/configure-attribute-excluded-user-store.png(line 393)
| updating these attributes may not work as expected. | ||
|
|
||
|
|
||
| 8. Under **Attribute Configurations**, use the table to configure how attributes are handled for each entity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix duplicate step numbering.
Both the "Attribute Configurations" section (line 404) and the "Attribute Mappings" section (line 444) are numbered as step 8. The Attribute Mappings section should be numbered as step 9.
Apply this diff to fix the step numbering:
- 8. Go to the **Attribute Mappings** tab and enter the attribute from each user store that you need to map.
+ 9. Go to the **Attribute Mappings** tab and enter the attribute from each user store that you need to map.Also applies to: 444-444
🤖 Prompt for AI Agents
In en/includes/guides/users/attributes/manage-attributes.md around line 404 (and
also at line 444), there's duplicate step numbering: the "Attribute
Configurations" section is step 8 and the "Attribute Mappings" section is also
labeled 8; change the numbering on the "Attribute Mappings" section at line 444
from "8." to "9." so the steps are sequential and unique.
Purpose
$subject
Related Issues
Related PRs
Test environment
Security checks
Summary by CodeRabbit