Add customizable AMR to the authenticators #850

Eranda2001 · 2025-02-25T11:12:17Z

Proposed Changes in this Pull Request

Bring First Class Support for Customizable AMR Values

Related Issues

Bring First Class Support for Customizable AMR Values product-is#23502

… updates

…s and updates

CLAassistant · 2025-02-25T11:12:25Z

All committers have signed the CLA.

...v1/src/gen/java/org/wso2/carbon/identity/api/server/authenticators/v1/AuthenticatorsApi.java

...gen/java/org/wso2/carbon/identity/api/server/authenticators/v1/AuthenticatorsApiService.java

.../carbon/identity/api/server/authenticators/v1/factories/AuthenticatorsApiServiceFactory.java

.../src/gen/java/org/wso2/carbon/identity/api/server/authenticators/v1/model/Authenticator.java

...1/src/gen/java/org/wso2/carbon/identity/api/server/authenticators/v1/model/ConnectedApp.java

.../src/gen/java/org/wso2/carbon/identity/api/server/authenticators/v1/model/ConnectedApps.java

...ators.v1/src/gen/java/org/wso2/carbon/identity/api/server/authenticators/v1/model/Error.java

.../wso2/carbon/identity/api/server/authenticators/v1/model/SystemLocalAuthenticatorUpdate.java

...arbon/identity/api/server/authenticators/v1/model/UserDefinedLocalAuthenticatorCreation.java

.../carbon/identity/api/server/authenticators/v1/model/UserDefinedLocalAuthenticatorUpdate.java

.../carbon/identity/api/server/authenticators/v1/core/ServerAuthenticatorManagementService.java

...org/wso2/carbon/identity/api/server/authenticators/v1/impl/AuthenticatorsApiServiceImpl.java

...arbon/identity/api/server/authenticators/v1/impl/LocalAuthenticatorConfigBuilderFactory.java

...org.wso2.carbon.identity.api.server.authenticators.v1/src/main/resources/authenticators.yaml

...src/gen/java/org/wso2/carbon/identity/api/server/configs/v1/model/AuthenticatorListItem.java

...v1/src/gen/java/org/wso2/carbon/identity/api/server/idp/v1/model/FederatedAuthenticator.java

...en/java/org/wso2/carbon/identity/api/server/idp/v1/model/FederatedAuthenticatorListItem.java

.../java/org/wso2/carbon/identity/api/server/idp/v1/model/FederatedAuthenticatorPUTRequest.java

...java/org/wso2/carbon/identity/api/server/idp/v1/model/FederatedUserDefinedAuthenticator.java

.../src/gen/java/org/wso2/carbon/identity/api/server/idp/v1/model/IdentityProviderResponse.java

...arbon/identity/api/server/authenticators/v1/impl/LocalAuthenticatorConfigBuilderFactory.java

.../carbon/identity/api/server/authenticators/v1/core/ServerAuthenticatorManagementService.java

.../wso2/carbon/identity/api/server/authenticators/v1/model/SystemLocalAuthenticatorUpdate.java

Eranda2001 · 2025-03-17T09:56:27Z

.../carbon/identity/api/server/authenticators/v1/core/ServerAuthenticatorManagementService.java

@@ -280,6 +281,32 @@ public Authenticator updateUserDefinedLocalAuthenticator(
        }
    }

+    public SystemLocalAuthenticatorUpdate updateSystemLocalAuthenticator(String authenticatorId,


Add comments

Eranda2001 · 2025-03-17T09:57:17Z

.../carbon/identity/api/server/authenticators/v1/core/ServerAuthenticatorManagementService.java

+            LocalAuthenticatorConfig localAuthenticatorConfig = new LocalAuthenticatorConfig();
+            localAuthenticatorConfig.setName(existingAuthenticator.getName());
+            localAuthenticatorConfig.setAmrValue(systemConfig.getAmrValue());
+            log.info("AMR Value: "+ systemConfig.getAmrValue());


Add a log with more info about the context

Eranda2001 · 2025-03-17T10:00:10Z

...org/wso2/carbon/identity/api/server/authenticators/v1/impl/AuthenticatorsApiServiceImpl.java

@@ -47,26 +52,26 @@ public AuthenticatorsApiServiceImpl() {
    }

    @Override
-    public Response authenticatorsGet(String filter, Integer limit, Integer offset) {


Change the order to it was

Eranda2001 · 2025-03-17T10:00:39Z

...org/wso2/carbon/identity/api/server/authenticators/v1/impl/AuthenticatorsApiServiceImpl.java

+    @Override
+    public Response updateSystemLocalAuthenticatorAmrValueById(String authenticatorId, SystemLocalAuthenticatorUpdate systemLocalAuthenticatorUpdate) {
+
+        return Response.ok().entity(authenticatorManagementService.updateSystemLocalAuthenticator(authenticatorId, systemLocalAuthenticatorUpdate)).build();


Check Formatting

shanggeeth · 2025-03-17T10:01:08Z

.../carbon/identity/api/server/authenticators/v1/core/ServerAuthenticatorManagementService.java

+            localAuthenticatorConfig.setAmrValue(systemConfig.getAmrValue());
+            log.info("AMR Value: "+ systemConfig.getAmrValue());
+            LocalAuthenticatorConfig updatedConfig = applicationAuthenticatorService
+                    .updateAuthenticatorAmrValue(localAuthenticatorConfig, tenantDomain);


Can we pass the existing authenticator object with the updated AMR values here ?

shanggeeth · 2025-03-17T10:05:33Z

pom.xml

+            <dependency>
+                <groupId>org.wso2.carbon.identity.framework</groupId>
+                <artifactId>org.wso2.carbon.identity.user.registration.mgt</artifactId>
+                <version>${carbon.identity.framework.version}</version>
+                <scope>provided</scope>
+            </dependency>
+            <dependency>
+                <groupId>org.wso2.carbon.identity.framework</groupId>
+                <artifactId>org.wso2.carbon.identity.user.registration.engine</artifactId>
+                <version>${carbon.identity.framework.version}</version>
+                <scope>provided</scope>
+            </dependency>


Is the registration service required for these changes ?

Eranda2001 added 6 commits February 19, 2025 11:03

Add AMR instance to federated authenticator payload for creations and…

ea52d74

… updates

Add AMR instance to local custom authenticator's payload for creation…

8f86fc4

…s and updates

Merge conflict resolve

e9a1473

AMR fixes

9df8988

Fixed conflicts

70a7ef8

Merge branch 'amr-custom-local' into feature-amr

811c53e

Eranda2001 assigned ThaminduR Feb 25, 2025

PR wso2#849 merged

27a0a4c