fix MessageMedia creator with remote file url#3645
Open
keelvin wants to merge 2 commits intowwebjs:mainfrom
Open
fix MessageMedia creator with remote file url#3645keelvin wants to merge 2 commits intowwebjs:mainfrom
keelvin wants to merge 2 commits intowwebjs:mainfrom
Conversation
Contributor
|
In my application, I download audios larger than 16MB, and send them in document format. Audio smaller than 16MB? send as audio. Is it bigger? as file. |
purpshell
approved these changes
Dec 16, 2025
Member
|
@keelvin will you update it to comply with the latest changes? Do you know if this fix is still necessary? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
Description
This PR enhances the
MessageMedia.fromUrl()method by adding comprehensive file size validation to prevent failures when attempting to send media files that exceed WhatsApp's size limits. The enhancement includes pre-download validation, specific limits per media type, and detailed error reporting.Key Changes:
Related Issue(s)
Motivation and Context
Problem Solved:
When using
MessageMedia.fromUrl()with large files (>64MB), the library would:WhatsApp Size Limits:
Why This Change is Required:
How Has This Been Tested
Test Scenarios:
Valid files within limits:
Files exceeding limits:
Edge cases:
Error Message Example:
Environment
await client.getWWebVersion())Types of changes
Checklist
Additional Notes
Backward Compatibility:
Performance Impact:
Error Handling:
Future Enhancements:
This change provides a foundation for potential future features like: