Skip to content

feat(client): add sendReaction method to the Client#4004

Open
maxkoryukov wants to merge 1 commit intowwebjs:mainfrom
volebo:feat/gl-0-client-send-reaction
Open

feat(client): add sendReaction method to the Client#4004
maxkoryukov wants to merge 1 commit intowwebjs:mainfrom
volebo:feat/gl-0-client-send-reaction

Conversation

@maxkoryukov
Copy link

PR Details

Add sendReaction method to the Client.

Description

The new method created from Message.react, and the original method now calls the new one.

Motivation and Context

With this method it is possible to send reactions to any message, not only to the just received message, or fetched by "load/fetch messages"

How Has This Been Tested

Basically, the code were just moved, so I called both:

  • msg.react
  • client.sendReaction

and both worked in private/group messages.

Environment

I've tested with [email protected] inside a node:24.11.0-alpine3.22 (linux) docker image.

webVersion: "2.3000.1030417076"

Types of changes

  • Dependency change
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (index.d.ts).
  • I have updated the usage example accordingly (example.js)

Copy link
Member

@purpshell purpshell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reasonable change, structure based methods should be mostly calling internal Client stuff anyways

@maxkoryukov
Copy link
Author

Hey, guys, can i fix something to make this PR easier to merge?

@BenyFilho
Copy link
Member

@maxkoryukov will you update it to comply with the latest changes? Do you know if this fix is still necessary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants