Open
Conversation
Member
|
Looks good but is clearly an AI PR that changes linting |
purpshell
requested changes
Feb 7, 2026
Member
purpshell
left a comment
There was a problem hiding this comment.
fix linting and make this solution more robust. Too many ambiguous helper functions and type unsafe logic.
The comments generated are also AI generated, and wipe out existing comments like the one for compareWWebVersions
Author
|
"Thanks for the feedback, @purpshell. |
Member
|
@Yaxhjagtap will you update it to comply with the latest changes? Do you know if this fix is still necessary? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
Updated
ExposeStoreto fully fix moduleRaid issues and make WhatsApp Web module loading future-proof.Description
getStoreFromModuleRaidto handle modules without.default.safeAssign) to prevent runtime crashes.window.Storeloads without errors even if some modules are renamed or missing.Related Issue(s)
TypeError: Cannot read properties of undefined (reading 'default').Motivation and Context
window.Storeinitialization to fail.window.Store.How Has This Been Tested
window.Storeloads without errors in WhatsApp Web v2.3000+.Chat,SendMessage,MediaUpload,GroupUtils.Chat.findImpl) work correctly.Environment
Types of changes
Checklist