fix: recreating keyboardShortcuts interface on file changes. #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nishu-murmu
changed the title
Timeraa
reviewed
Mar 4, 2025
Yeah, now that I think about it, it really can be. as such there are already existing issues for windows. |
aleclarson
suggested changes
Mar 22, 2025
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/storage
@wxt-dev/unocss
wxt
commit: |
aleclarson
reviewed
Mar 24, 2025
aklinker1
reviewed
Mar 29, 2025
Comment on lines
-114
to
-120
| const reloadOnChange = createFileReloader(server); | ||
| const reloadOnChange = () => { | ||
| keyboardShortcuts.start(); | ||
| keyboardShortcuts.printHelp({ | ||
| canReopenBrowser: | ||
| !wxt.config.runnerConfig.config.disabled && !!runner.canOpen?.(), | ||
| }); | ||
| return createFileReloader(server); | ||
| }; | ||
| server.watcher.on('all', reloadOnChange); | ||
| keyboardShortcuts.start(); | ||
| keyboardShortcuts.printHelp({ | ||
| canReopenBrowser: | ||
| !wxt.config.runnerConfig.config.disabled && !!runner.canOpen?.(), | ||
| }); |
There was a problem hiding this comment.
One side-effect to this change is that the help message is printed after every file is saved, right? Should we leave the printHelp call outside the reloadOnChange where it was before so we only print the message when the server is started/restarted?
aklinker1
requested changes
Mar 29, 2025
Comment on lines
+114
to
122
| const reloadOnChange = () => { | ||
| keyboardShortcuts.start(); | ||
| keyboardShortcuts.printHelp({ | ||
| canReopenBrowser: | ||
| !wxt.config.runnerConfig.config.disabled && !!runner.canOpen?.(), | ||
| }); | ||
| return createFileReloader(server); | ||
| }; | ||
| server.watcher.on('all', reloadOnChange); |
There was a problem hiding this comment.
I think this change is still wrong... The file watcher args aren't being passed into the function returned by createFileReloader properly.
This is the right way to do it:
Suggested change
| const reloadOnChange = () => { | |
| keyboardShortcuts.start(); | |
| keyboardShortcuts.printHelp({ | |
| canReopenBrowser: | |
| !wxt.config.runnerConfig.config.disabled && !!runner.canOpen?.(), | |
| }); | |
| return createFileReloader(server); | |
| }; | |
| server.watcher.on('all', reloadOnChange); | |
| const reloadOnChange = createFileReloader(server); | |
| server.watcher.on('all', async (...args) => { | |
| await reloadOnChange(...args); | |
| // Restart keyboard shortcuts after file is changed - for some reason they stop working. | |
| keyboardShortcuts.start(); | |
| }); | |
| keyboardShortcuts.printHelp({ | |
| canReopenBrowser: | |
| !wxt.config.runnerConfig.config.disabled && !!runner.canOpen?.(), | |
| }); |
I also included moving the printHelp call out so it's only printed once. See #1465 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I noticed that keyboard shortcuts weren't working after files were being saved or HMR was triggered.
Hope this fixes it.