fix: exclude files in .zip except those with a bang ! #1517
+29
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nishu-murmu
changed the title
|
Do I need to add some test cases for these fix? |
aklinker1
requested changes
Mar 29, 2025
There was a problem hiding this comment.
Thanks for the PR! We need to add some tests around these changes:
https://github.com/wxt-dev/wxt/blob/main/packages/wxt/e2e/tests/zip.test.ts
packages/wxt/src/core/zip.ts
Outdated
Comment on lines
124
to
132
| function negateCheck() { | ||
| return options?.exclude?.some( | ||
| (option) => | ||
| option.startsWith('!') && minimatch(relativePath, option.slice(1)), | ||
| ); | ||
| } | ||
| if (negateCheck()) { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
Suggested change
| function negateCheck() { | |
| return options?.exclude?.some( | |
| (option) => | |
| option.startsWith('!') && minimatch(relativePath, option.slice(1)), | |
| ); | |
| } | |
| if (negateCheck()) { | |
| return true; | |
| } | |
| const isNegated = options?.exclude?.some( | |
| (option) => | |
| option.startsWith('!') && minimatch(relativePath, option.slice(1)), | |
| ); | |
| if (isNegated) return true; |
…o fix/zip-exclude-bang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is issue reproduction repo: https://github.com/skube/min-repro-wxt
Here is the discussion about creating this PR and more context.
#1510 (comment)
This PR closes #1510