feat: Ignore popup/index.ts instead of erroring #1520
+12
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
aleclarson
reviewed
Mar 22, 2025
| 'popup/index.html', | ||
| 'popup/index.ts', | ||
| 'ui.html', | ||
| ]); | ||
| expect(() => findEntrypoints()); |
There was a problem hiding this comment.
this doesn't actually check anything. needs to be awaited and use .resolves API
aleclarson
reviewed
Mar 22, 2025
| await expect(() => findEntrypoints()).rejects.toThrowError( | ||
| [ | ||
| 'Multiple entrypoints with the same name detected, only one entrypoint for each name is allowed.', | ||
| '', |
There was a problem hiding this comment.
still want this empty string, i think?
aleclarson
reviewed
Mar 22, 2025
| '- popup', | ||
| ` - ${unnormalizePath('src/entrypoints/popup.html')}`, | ||
| ` - ${unnormalizePath('src/entrypoints/popup/index.html')}`, | ||
| ` - ${unnormalizePath('src/entrypoints/popup/index.ts')}`, | ||
| ``, |
There was a problem hiding this comment.
don't want this empty string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
#1333
Manual Testing
I still wasn't able to work the second test work. Could use some help.
Related Issue
This PR closes #1333