Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add JSDoc type annotation to auto-imports for ESlint #1558

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nostrorom
Copy link

@nostrorom nostrorom commented Apr 2, 2025

Overview

Add type annotation for auto-imports (ESLint 9). If typechecked, eslint.config.js may pop an error:

      The types of 'languageOptions.sourceType' are incompatible between these types.
        Type 'string' is not assignable to type 'SourceType | undefined'.ts(2322)

Manual Testing

On a project running checks on JS, IDE should not show squiggly lines

Related Issue

No related issue

Copy link

netlify bot commented Apr 2, 2025

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 36d326c
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/67f3a0ceabedf40008e21e8b
😎 Deploy Preview https://deploy-preview-1558--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nostrorom nostrorom changed the title add JSDoc type annotation to auto-imports for ESlint fix: add JSDoc type annotation to auto-imports for ESlint Apr 2, 2025
Copy link

pkg-pr-new bot commented Apr 6, 2025

Open in StackBlitz

@wxt-dev/analytics

npm i https://pkg.pr.new/@wxt-dev/analytics@1558

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@1558

@wxt-dev/browser

npm i https://pkg.pr.new/@wxt-dev/browser@1558

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@1558

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@1558

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@1558

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@1558

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@1558

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@1558

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@1558

@wxt-dev/webextension-polyfill

npm i https://pkg.pr.new/@wxt-dev/webextension-polyfill@1558

wxt

npm i https://pkg.pr.new/wxt@1558

commit: d56b3ce

@aklinker1
Copy link
Collaborator

Looks like a test snapshot needs updated. Run pnpm test to see the changes. If they're OK, type u to update them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants