Skip to content

Add short tag name option for nested tag helpers #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add short tag name option for nested tag helpers #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions src/GovUk.Frontend.AspNetCore.DocSamples/Pages/Accordion/AccordionWithSummarySections.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
@page

<govuk-accordion id="accordion-with-summary-sections" heading-level="3">
<govuk-accordion-item expanded="true">
<govuk-accordion-item-heading>Understanding agile project management</govuk-accordion-item-heading>
<govuk-accordion-item-summary>Introductions, methods, core features.</govuk-accordion-item-summary>
<accordion-item expanded="true">
<heading>Understanding agile project management</heading>
<summary>Introductions, methods, core features.</summary>
<ul class="govuk-list">
<li>
<a class="govuk-link" href="#">Agile and government services: an introduction</a>
Expand All @@ -15,10 +15,10 @@
<a class="govuk-link" href="#">Core principles of agile</a>
</li>
</ul>
</govuk-accordion-item>
<govuk-accordion-item>
<govuk-accordion-item-heading>Working with agile methods</govuk-accordion-item-heading>
<govuk-accordion-item-summary>Workspaces, tools and techniques, user stories, planning.</govuk-accordion-item-summary>
</accordion-item>
<accordion-item>
<heading>Working with agile methods</heading>
<summary>Workspaces, tools and techniques, user stories, planning.</summary>
<ul class="govuk-list">
<li>
<a class="govuk-link" href="#">Creating an agile working environment</a>
Expand All @@ -42,10 +42,10 @@
<a class="govuk-link" href="#">Developing a roadmap</a>
</li>
</ul>
</govuk-accordion-item>
<govuk-accordion-item>
<govuk-accordion-item-heading>Governing agile services</govuk-accordion-item-heading>
<govuk-accordion-item-summary>Principles, measuring progress, spending money.</govuk-accordion-item-summary>
</accordion-item>
<accordion-item>
<heading>Governing agile services</heading>
<summary>Principles, measuring progress, spending money.</summary>
<ul class="govuk-list">
<li>
<a class="govuk-link" href="#">Governance principles for agile service delivery</a>
Expand All @@ -66,10 +66,10 @@
<a class="govuk-link" href="#">Working across organisational boundaries</a>
</li>
</ul>
</govuk-accordion-item>
<govuk-accordion-item>
<govuk-accordion-item-heading>Phases of an agile project</govuk-accordion-item-heading>
<govuk-accordion-item-summary>Discovery, alpha, beta, live and retirement.</govuk-accordion-item-summary>
</accordion-item>
<accordion-item>
<heading>Phases of an agile project</heading>
<summary>Discovery, alpha, beta, live and retirement.</summary>
<ul class="govuk-list">
<li>
<a class="govuk-link" href="#">How the discovery phase works</a>
Expand All @@ -87,5 +87,5 @@
<a class="govuk-link" href="#">Retiring your service</a>
</li>
</ul>
</govuk-accordion-item>
</accordion-item>
</govuk-accordion>
6 changes: 3 additions & 3 deletions src/GovUk.Frontend.AspNetCore.DocSamples/Pages/Breadcrumbs/Breadcrumbs.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
@page

<govuk-breadcrumbs collapse-on-mobile="true">
<govuk-breadcrumbs-item asp-controller="Home" asp-action="Index">Home</govuk-breadcrumbs-item>
<govuk-breadcrumbs-item href="#" link-target="_blank">Passports, travel and living abroad</govuk-breadcrumbs-item>
<govuk-breadcrumbs-item>Travel abroad</govuk-breadcrumbs-item>
<breadcrumbs-item asp-controller="Home" asp-action="Index">Home</breadcrumbs-item>
<breadcrumbs-item href="#" link-target="_blank">Passports, travel and living abroad</breadcrumbs-item>
<breadcrumbs-item>Travel abroad</breadcrumbs-item>
</govuk-breadcrumbs>
8 changes: 4 additions & 4 deletions src/GovUk.Frontend.AspNetCore.DocSamples/Pages/CharacterCount/CharacterCount.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
@page

<govuk-character-count name="more-detail" max-length="200">
<govuk-character-count-label class="govuk-label--l" is-page-heading="true">
<label class="govuk-label--l" is-page-heading="true">
Can you provide more detail?
</govuk-character-count-label>
<govuk-character-count-hint>
</label>
<hint>
Do not include personal or financial information like your National Insurance number or credit card details.
</govuk-character-count-hint>
</hint>
</govuk-character-count>
22 changes: 11 additions & 11 deletions src/GovUk.Frontend.AspNetCore.DocSamples/Pages/Checkboxes/Checkboxes.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
@page

<govuk-checkboxes name="nationality">
<govuk-checkboxes-fieldset>
<govuk-checkboxes-fieldset-legend is-page-heading="true" class="govuk-fieldset__legend--l">
<checkboxes-fieldset>
<legend is-page-heading="true" class="govuk-fieldset__legend--l">
What is your nationality?
</govuk-checkboxes-fieldset-legend>
</legend>

<govuk-checkboxes-hint>
<hint>
If you have dual nationality, select all options that are relevant to you.
</govuk-checkboxes-hint>
</hint>

<govuk-checkboxes-item value="british">
<checkboxes-item value="british">
British
<govuk-checkboxes-item-hint>including English, Scottish, Welsh and Northern Irish</govuk-checkboxes-item-hint>
</govuk-checkboxes-item>
<govuk-checkboxes-item value="irish">Irish</govuk-checkboxes-item>
<govuk-checkboxes-item value="other">Citizen of another country</govuk-checkboxes-item>
</govuk-checkboxes-fieldset>
<hint>including English, Scottish, Welsh and Northern Irish</hint>
</checkboxes-item>
<checkboxes-item value="irish">Irish</checkboxes-item>
<checkboxes-item value="other">Citizen of another country</checkboxes-item>
</checkboxes-fieldset>
</govuk-checkboxes>
42 changes: 21 additions & 21 deletions src/GovUk.Frontend.AspNetCore.DocSamples/Pages/Checkboxes/CheckboxesWithConditional.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,40 +1,40 @@
@page

<govuk-checkboxes name="contact">
<govuk-checkboxes-fieldset>
<govuk-checkboxes-fieldset-legend is-page-heading="true" class="govuk-fieldset__legend--l">
<checkboxes-fieldset>
<legend is-page-heading="true" class="govuk-fieldset__legend--l">
How would you like to be contacted?
</govuk-checkboxes-fieldset-legend>
</legend>

<govuk-checkboxes-hint>
<hint>
Select all options that are relevant to you.
</govuk-checkboxes-hint>
</hint>

<govuk-checkboxes-item value="email">
<checkboxes-item value="email">
Email
<govuk-checkboxes-item-conditional>
<conditional>
<govuk-input name="contact-by-email" type="email" autocomplete="email" spellcheck="false" input-class="govuk-!-width-one-third">
<govuk-input-label>Email address</govuk-input-label>
<label>Email address</label>
</govuk-input>
</govuk-checkboxes-item-conditional>
</govuk-checkboxes-item>
</conditional>
</checkboxes-item>

<govuk-checkboxes-item value="phone">
<checkboxes-item value="phone">
Phone
<govuk-checkboxes-item-conditional>
<conditional>
<govuk-input name="contact-by-phone" type="tel" autocomplete="tel" input-class="govuk-!-width-one-third">
<govuk-input-label>Phone number</govuk-input-label>
<label>Phone number</label>
</govuk-input>
</govuk-checkboxes-item-conditional>
</govuk-checkboxes-item>
</conditional>
</checkboxes-item>

<govuk-checkboxes-item value="text message">
<checkboxes-item value="text message">
Text message
<govuk-checkboxes-item-conditional>
<conditional>
<govuk-input name="contact-by-text" type="tel" autocomplete="tel" input-class="govuk-!-width-one-third">
<govuk-input-label>Mobile phone number</govuk-input-label>
<label>Mobile phone number</label>
</govuk-input>
</govuk-checkboxes-item-conditional>
</govuk-checkboxes-item>
</govuk-checkboxes-fieldset>
</conditional>
</checkboxes-item>
</checkboxes-fieldset>
</govuk-checkboxes>
24 changes: 12 additions & 12 deletions src/GovUk.Frontend.AspNetCore.DocSamples/Pages/Checkboxes/CheckboxesWithError.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,24 @@
@page

<govuk-checkboxes name="nationality">
<govuk-checkboxes-fieldset>
<govuk-checkboxes-fieldset-legend is-page-heading="true" class="govuk-fieldset__legend--l">
<checkboxes-fieldset>
<legend is-page-heading="true" class="govuk-fieldset__legend--l">
What is your nationality?
</govuk-checkboxes-fieldset-legend>
</legend>

<govuk-checkboxes-hint>
<hint>
If you have dual nationality, select all options that are relevant to you.
</govuk-checkboxes-hint>
</hint>

<govuk-checkboxes-error-message>
<error-message>
Select if you are British, Irish or a citizen of a different country
</govuk-checkboxes-error-message>
</error-message>

<govuk-checkboxes-item value="british">
<checkboxes-item value="british">
British
<govuk-checkboxes-item-hint>including English, Scottish, Welsh and Northern Irish</govuk-checkboxes-item-hint>
</govuk-checkboxes-item>
<govuk-checkboxes-item value="irish">Irish</govuk-checkboxes-item>
<govuk-checkboxes-item value="other">Citizen of another country</govuk-checkboxes-item>
</govuk-checkboxes-fieldset>
</checkboxes-item>
<checkboxes-item value="irish">Irish</checkboxes-item>
<checkboxes-item value="other">Citizen of another country</checkboxes-item>
</checkboxes-fieldset>
</govuk-checkboxes>
22 changes: 11 additions & 11 deletions src/GovUk.Frontend.AspNetCore.DocSamples/Pages/Checkboxes/CheckboxesWithNone.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
@page

<govuk-checkboxes name="countries">
<govuk-checkboxes-fieldset>
<govuk-checkboxes-fieldset-legend is-page-heading="true" class="govuk-fieldset__legend--l">
<checkboxes-fieldset>
<legend is-page-heading="true" class="govuk-fieldset__legend--l">
Will you be travelling to any of these countries?
</govuk-checkboxes-fieldset-legend>
</legend>

<govuk-checkboxes-hint>
<hint>
Select all countries that apply
</govuk-checkboxes-hint>
</hint>

<govuk-checkboxes-item value="france">France</govuk-checkboxes-item>
<govuk-checkboxes-item value="portugal">Portugal</govuk-checkboxes-item>
<govuk-checkboxes-item value="spain">Spain</govuk-checkboxes-item>
<govuk-checkboxes-divider>or</govuk-checkboxes-divider>
<govuk-checkboxes-item value="none" behavior="Exclusive">No, I will not be travelling to any of these countries</govuk-checkboxes-item>
</govuk-checkboxes-fieldset>
<checkboxes-item value="france">France</checkboxes-item>
<checkboxes-item value="portugal">Portugal</checkboxes-item>
<checkboxes-item value="spain">Spain</checkboxes-item>
<checkboxes-divider>or</checkboxes-divider>
<checkboxes-item value="none" behavior="Exclusive">No, I will not be travelling to any of these countries</checkboxes-item>
</checkboxes-fieldset>
</govuk-checkboxes>
4 changes: 2 additions & 2 deletions src/GovUk.Frontend.AspNetCore.DocSamples/Pages/Checkboxes/CheckboxesWithoutFieldset.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
@page

<govuk-checkboxes name="t-and-c">
<govuk-checkboxes-item value="yes">
<checkboxes-item value="yes">
I agree to the terms and conditions
</govuk-checkboxes-item>
</checkboxes-item>
</govuk-checkboxes>
18 changes: 9 additions & 9 deletions ...GovUk.Frontend.AspNetCore.DocSamples/Pages/DateInput/DateInputWithCustomItemLabels.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
@page

<govuk-date-input id="passport-issued" name-prefix="passport-issued">
<govuk-date-input-day>
<govuk-date-input-day-label>Dydd</govuk-date-input-day-label>
</govuk-date-input-day>
<govuk-date-input-month>
<govuk-date-input-month-label>Mis</govuk-date-input-month-label>
</govuk-date-input-month>
<govuk-date-input-year>
<govuk-date-input-year-label>Blwyddyn</govuk-date-input-year-label>
</govuk-date-input-year>
<day>
<label>Dydd</label>
</day>
<month>
<label>Mis</label>
</month>
<year>
<label>Blwyddyn</label>
</year>
</govuk-date-input>
6 changes: 3 additions & 3 deletions ...GovUk.Frontend.AspNetCore.DocSamples/Pages/DateInput/DateInputWithCustomItemValues.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
@page

<govuk-date-input id="passport-issued" name-prefix="passport-issued">
<govuk-date-input-day value="1" />
<govuk-date-input-month value="4" />
<govuk-date-input-year value="2022" />
<day value="1" />
<month value="4" />
<year value="2022" />
</govuk-date-input>
4 changes: 2 additions & 2 deletions src/GovUk.Frontend.AspNetCore.DocSamples/Pages/DateInput/DateInputWithError.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
@page

<govuk-date-input id="passport-issued" name-prefix="passport-issued">
<govuk-date-input-error-message>
<error-message>
The date your passport was issued must be in the past
</govuk-date-input-error-message>
</error-message>
</govuk-date-input>
16 changes: 8 additions & 8 deletions src/GovUk.Frontend.AspNetCore.DocSamples/Pages/DateInput/DateInputWithFieldset.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
@page

<govuk-date-input id="passport-issued" name-prefix="passport-issued">
<govuk-date-input-fieldset>
<govuk-date-input-fieldset-legend is-page-heading="true" class="govuk-fieldset__legend--l">
<date-input-fieldset>
<legend is-page-heading="true" class="govuk-fieldset__legend--l">
When was your passport issued?
</govuk-date-input-fieldset-legend>
<govuk-date-input-hint>
</legend>
<hint>
For example, 27 3 2007
</govuk-date-input-hint>
<govuk-date-input-error-message>
</hint>
<error-message>
The date your passport was issued must be in the past
</govuk-date-input-error-message>
</govuk-date-input-fieldset>
</error-message>
</date-input-fieldset>
</govuk-date-input>
8 changes: 4 additions & 4 deletions src/GovUk.Frontend.AspNetCore.DocSamples/Pages/Details/Details.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
@page

<govuk-details>
<govuk-details-summary>
<summary>
Help with nationality
</govuk-details-summary>
<govuk-details-text>
</summary>
<text>
We need to know your nationality so we can work out which elections you’re entitled to vote in.
If you cannot provide your nationality, you’ll have to send copies of identity documents through the post.
</govuk-details-text>
</text>
</govuk-details>
8 changes: 4 additions & 4 deletions src/GovUk.Frontend.AspNetCore.DocSamples/Pages/Details/DetailsExpanded.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
@page

<govuk-details open="true">
<govuk-details-summary>
<summary>
Help with nationality
</govuk-details-summary>
<govuk-details-text>
</summary>
<text>
We need to know your nationality so we can work out which elections you’re entitled to vote in.
If you cannot provide your nationality, you’ll have to send copies of identity documents through the post.
</govuk-details-text>
</text>
</govuk-details>
4 changes: 2 additions & 2 deletions src/GovUk.Frontend.AspNetCore.DocSamples/Pages/ErrorSummary/ErrorSummary.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
@page

<govuk-error-summary>
<govuk-error-summary-item href="#passport-issued-day">The date your passport was issued must be in the past</govuk-error-summary-item>
<govuk-error-summary-item href="#postcode-input">Enter a postcode, like AA1 1AA</govuk-error-summary-item>
<error-item href="#passport-issued-day">The date your passport was issued must be in the past</error-item>
<error-item href="#postcode-input">Enter a postcode, like AA1 1AA</error-item>
</govuk-error-summary>
2 changes: 1 addition & 1 deletion ....Frontend.AspNetCore.DocSamples/Pages/ErrorSummary/ErrorSummaryWithModelStateError.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
@model ErrorSummaryWithModelStateErrorModel

<govuk-error-summary>
<govuk-error-summary-item asp-for="FullName" />
<error-item asp-for="FullName" />
</govuk-error-summary>
6 changes: 3 additions & 3 deletions src/GovUk.Frontend.AspNetCore.DocSamples/Pages/ErrorSummary/ErrorSummaryWithTitle.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
@page

<govuk-error-summary>
<govuk-error-summary-title>There is a problem</govuk-error-summary-title>
<govuk-error-summary-item href="#passport-issued-day">The date your passport was issued must be in the past</govuk-error-summary-item>
<govuk-error-summary-item href="#postcode-input">Enter a postcode, like AA1 1AA</govuk-error-summary-item>
<title>There is a problem</title>
<error-item href="#passport-issued-day">The date your passport was issued must be in the past</error-item>
<error-item href="#postcode-input">Enter a postcode, like AA1 1AA</error-item>
</govuk-error-summary>
2 changes: 1 addition & 1 deletion src/GovUk.Frontend.AspNetCore.DocSamples/Pages/Fieldset/Fieldset.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@page

<govuk-fieldset>
<govuk-fieldset-legend is-page-heading="true" class="govuk-fieldset__legend--l">Legend as page heading</govuk-fieldset-legend>
<legend is-page-heading="true" class="govuk-fieldset__legend--l">Legend as page heading</legend>
</govuk-fieldset>
Loading