Conversation
Add comprehensive test coverage for gen/rpc.go, following the same patterns used by sqlx_test.go and api_test.go. Test cases include: - success: basic RPC interface generation - success_pointer_reply: RPC with pointer return type - success_nort: RPC with rpc/nort feature flag - fail_no_input: method without input parameter - fail_too_many_inputs: method with more than 1 input - fail_no_output: method without output parameters - fail_one_output: method with only 1 output - fail_too_many_outputs: method with more than 2 outputs - fail_no_error: method without error as second output - fail_no_name_type: method without named parameter - fail_no_type_decl: no type declaration found - fail_no_iface_type: no interface type found 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gen/rpc.goingen/rpc_test.gogen/testdata/rpc/test.gofollowing the existing patterns from sqlx and api testsTest Cases
successsuccess_pointer_replysuccess_nortrpc/nortfeature flagfail_no_inputfail_too_many_inputsfail_no_outputfail_one_outputfail_too_many_outputsfail_no_errorfail_no_name_typefail_no_type_declfail_no_iface_typeTest plan
go test -v -run TestBuildRpc ./gen./test.shgo vet ./gen/*.go🤖 Generated with Claude Code