Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/memory-runtime.ts
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,10 @@ function normalizeSearchCorpus(value: unknown): "all" | "memory" | "sessions" {
function parseMetadataJson(item: { metadataJson?: Uint8Array }): Record<string, unknown> {
if (item.metadataJson && item.metadataJson.length > 0) {
try {
return JSON.parse(new TextDecoder().decode(item.metadataJson));
const parsed = JSON.parse(new TextDecoder().decode(item.metadataJson)) as unknown;
if (parsed && typeof parsed === "object" && !Array.isArray(parsed)) {
return parsed as Record<string, unknown>;
}
} catch (e) {
// ignore
}
Expand Down
29 changes: 29 additions & 0 deletions test/unit/memory-runtime.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,35 @@ test("memory runtime bridge falls back to metadata text when search result text
assert.equal(loaded.text, metadataText);
});

test("memory runtime bridge treats non-object metadata JSON as missing", async () => {
const rpc = new FakeRpc();
(rpc as { searchTextCollections: (params: Record<string, unknown>) => Promise<{ results: unknown[] }> }).searchTextCollections = async (params) => {
rpc.calls.push({ method: "searchTextCollections", params });
return {
results: [
{
id: "turn-1",
score: 0.88,
text: "remembered item survives non-object metadata",
metadataJson: new TextEncoder().encode("null"),
},
],
};
};
const runtime = buildMemoryRuntimeBridge(async () => rpc as never, {});
const { manager } = await runtime.getMemorySearchManager();

const result = await manager.search({ query: "remembered item", sessionId: "s1" }) as Array<{
path: string;
snippet: string;
source: string;
}>;

assert.equal(result.length, 1);
assert.equal(result[0]?.snippet, "remembered item survives non-object metadata");
assert.equal(result[0]?.source, "memory");
});

test("memory runtime bridge does not authorize hidden paths from legacy search results", async () => {
const rpc = new FakeRpc();
const runtime = buildMemoryRuntimeBridge(async () => rpc as never, {});
Expand Down
Loading