fix: sanitize multiline tool-call JSON - #370
Conversation
|
Warning Review limit reached
Next review available in: 59 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Vale Review — PR #370Quality: Q4/5 — sharp Findings:
Proof gaps: No local gate run in this worker; PR reports TypeScript and the focused context-engine unit coverage. Verdict: comment-only — self-authored PR, focused fix, no current-head blocker found. – Vale |
Summary
Root cause
TOOL_CALL_JSON_REused[^\r\n]*, so it could never match a formatted JSON object across line breaks. Simply changing it to a cross-line wildcard would risk consuming from an earlier ordinary object through a later tool call, especially with nested arguments.Impact
Historical multiline tool-call JSON is now removed from recalled context before it can prime a model to repeat tool syntax, without deleting neighboring ordinary structured memory.
Verification
pnpm exec tsc --noEmit.ts-build/test/unit/context-engine.test.js— 74/74 passedgit diff --checkFixes #353.
– Vale