Skip to content

feat: support heatmap and also highlight in py-maidr using maidr-ts #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dakshpokar
Copy link
Collaborator

Description

This PR adds support for heatmap in py-maidr using maidr-ts.
Note that we need to merge this PR after merging: #153.
Also furthermore, once this PR is merged we will be deprecating support for heatmap using maidr js. So the only way to have heatmap with maidr support in py-maidr is to use maidr ts.

Type of Change

  • Bug fix
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Additional Notes

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

maidr/core/maidr.py:169

  • [nitpick] Consider using a clearer iteration method such as 'for index, sel in enumerate(schema[MaidrKey.SELECTOR])' to improve code readability when updating each selector string.
if isinstance(schema[MaidrKey.SELECTOR], list):

@xability xability deleted a comment from Copilot AI Apr 10, 2025
@dakshpokar dakshpokar changed the base branch from main to feat/maidr-ts-migration-phase-2 April 15, 2025 15:30
@dakshpokar dakshpokar merged commit d998f9a into feat/maidr-ts-migration-phase-2 Apr 15, 2025
3 checks passed
@dakshpokar dakshpokar deleted the feat/support-heatmap-using-maidr-ts branch April 15, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants