-
Notifications
You must be signed in to change notification settings - Fork 3
feat: support dodged and stacked bar plots using maidr-ts #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dakshpokar
merged 14 commits into
feat/maidr-ts-migration-phase-2
from
feat/dodged-stacked-bar-plot
Apr 15, 2025
Merged
feat: support dodged and stacked bar plots using maidr-ts #156
dakshpokar
merged 14 commits into
feat/maidr-ts-migration-phase-2
from
feat/dodged-stacked-bar-plot
Apr 15, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to feat/support-heatmap-using-maidr-ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (4)
maidr/core/plot/lineplot.py:45
- The _get_selector method now returns a list instead of a string; please ensure that any downstream code that consumes this selector is updated in accordance with the new return type.
def _get_selector(self) -> list[str]:
maidr/core/plot/grouped_barplot.py:54
- The refactoring now accumulates data in a nested list (container_data) before appending to the outer list. Verify that this new nested structure is consistent with how grouped bar data is consumed downstream.
container_data.append({
maidr/core/maidr.py:168
- Since the MaidrKey enum now maps SELECTOR to "selectors", please confirm that the schema replacement logic correctly handles both string and list values without introducing inconsistencies in the final schema.
if isinstance(schema[MaidrKey.SELECTOR], str):
example/count/example_count_plot.ipynb:95
- [nitpick] The notebook metadata version was altered from 3.12.6 to 3.10.12; please verify that this downgrade is intentional and does not conflict with other package version dependencies.
"version": "3.10.12"
jooyoungseo
approved these changes
Apr 10, 2025
…backwards compatibility
…o feat/dodged-stacked-bar-plot
…-ts' into feat/scatter-plot-highlight
…o feat/dodged-stacked-bar-plot
10 tasks
… into feat/dodged-stacked-bar-plot
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for Dodged and Stacked Bar plots using maidr ts engine.
Please merge this PR after merging: #153.
Also, merging this PR means we can't use JavaScript engine for Dodged and Stacked Bar Plots.
Type of Change
Checklist
Additional Notes