Skip to content

feat: support dodged and stacked bar plots using maidr-ts #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dakshpokar
Copy link
Collaborator

Description

This PR adds support for Dodged and Stacked Bar plots using maidr ts engine.
Please merge this PR after merging: #153.
Also, merging this PR means we can't use JavaScript engine for Dodged and Stacked Bar Plots.

Type of Change

  • Bug fix
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Additional Notes

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (4)

maidr/core/plot/lineplot.py:45

  • The _get_selector method now returns a list instead of a string; please ensure that any downstream code that consumes this selector is updated in accordance with the new return type.
def _get_selector(self) -> list[str]:

maidr/core/plot/grouped_barplot.py:54

  • The refactoring now accumulates data in a nested list (container_data) before appending to the outer list. Verify that this new nested structure is consistent with how grouped bar data is consumed downstream.
container_data.append({

maidr/core/maidr.py:168

  • Since the MaidrKey enum now maps SELECTOR to "selectors", please confirm that the schema replacement logic correctly handles both string and list values without introducing inconsistencies in the final schema.
if isinstance(schema[MaidrKey.SELECTOR], str):

example/count/example_count_plot.ipynb:95

  • [nitpick] The notebook metadata version was altered from 3.12.6 to 3.10.12; please verify that this downgrade is intentional and does not conflict with other package version dependencies.
"version": "3.10.12"

@dakshpokar dakshpokar changed the base branch from main to feat/maidr-ts-migration-phase-2 April 15, 2025 15:37
@dakshpokar dakshpokar merged commit efde16d into feat/maidr-ts-migration-phase-2 Apr 15, 2025
3 checks passed
@dakshpokar dakshpokar deleted the feat/dodged-stacked-bar-plot branch April 15, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants