This repository has been archived by the owner on May 1, 2024. It is now read-only.
CameraView images automatically rotate on Android #1871
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Bug
Not sure if this is the full, final implementation yet because techinically this is a breaking change. The rotation of the image taken with
CameraView
on Android will be done automatically with this fix.Earlier we "fixed" this bug by providing the rotation information and users had to rotate the image manually. This code will rotate the image automatically for them. But if users have the rotation fix in their app, now it will probably start showing up weird.
Issues Fixed
Behavioral Changes
Take a picture with CameraView on Android and notice the picture shows up the right way.
PR Checklist
approved