This repository has been archived by the owner on May 1, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Bug
On Android, the camera activity is correctly rotated, but the resulting image isn't rotated according to the current device orientation. Instead the rotation angle is passed to the event
RaiseMediaCaptured
. The PR takes the changes from @jfversluis from PR #1871, which already does the image rotation, and passes rotation angle 0 toRaiseMediaCaptured
in order to be compatible with potentially existing rotation code on user's side.Note that this change targets the droid-cameraview-rotation branch that @jfversluis already has done the main work, per PR #1871.
Issues Fixed
Behavioral Changes
There should be no changes, since the photo now has been rotated already and the new rotation angle 0 is passed to the user.
PR Checklist
approved