CP-309728 Move XS related PVS target key to xapi.conf #6706
+9
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lunfan Zhang[Lunfan.Zhang] <[email protected]>
psafont
approved these changes
Oct 13, 2025
changlei-li
approved these changes
Oct 13, 2025
lindig
approved these changes
Oct 13, 2025
| (fun s -> s) | ||
| disable_dbsync_for | ||
| ; gen_list_option "guest-service-keys" | ||
| "space-separated list of guest service keys to monitor in xenstore" |
There was a problem hiding this comment.
This says space separated but other lists are using a comma. I would prefer this to be consistent. A comma would be more shell friendly.
There was a problem hiding this comment.
I see at least three other lists that state they are space-separated, xenopsd_queues seems to be the exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pvs_target/target_software_versionis XS specific configuration, move it fromxapi_globstoxapi.conf.