Skip to content

[Piers] Add game.shader.presets #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: Piers
Choose a base branch
from
Open

Conversation

garbear
Copy link
Member

@garbear garbear commented Jun 5, 2025

Description

As title says, this adds game.shader.presets to the list of add-ons for the Piers branch.

I put "all" for platforms to see what it builds on. Or, we can decide which platforms we want instead.

Motivation and Context

Needed after xbmc/xbmc#26435.

How has this been tested?

This commit has been in my RetroPlayer builds since 2017.

@garbear garbear requested a review from Copilot June 5, 2025 01:33
Copilot

This comment was marked as outdated.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds the game.shader.presets add-on to the Piers branch registry and marks it for all platforms

  • Updates platforms.txt to include “all” platforms
  • Registers the add-on in game.shader.presets.txt with its GitHub URL and Piers branch

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
game.shader.presets/platforms.txt Added “all” to specify that the add-on should build on every platform
game.shader.presets/game.shader.presets.txt Added an entry with the add-on ID, repository URL, and branch name
Comments suppressed due to low confidence (1)

game.shader.presets/platforms.txt:1

  • Specifying “all” will trigger builds on every platform, including those that may not be supported or tested. Consider listing only the platforms where this add-on has been verified to avoid CI failures or unnecessary build time.
all

@@ -0,0 +1 @@
all
Copy link
Preview

Copilot AI Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a trailing newline to this file to comply with POSIX text file conventions and ensure any scripts parsing it handle the final line correctly.

Copilot uses AI. Check for mistakes.

@@ -0,0 +1 @@
game.shader.presets https://github.com/kodi-game/game.shader.presets Piers
Copy link
Preview

Copilot AI Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, add a trailing newline here to conform with standard text file formatting and prevent potential parsing issues in the add-on registry loader.

Copilot uses AI. Check for mistakes.

@garbear
Copy link
Member Author

garbear commented Jun 5, 2025

Do we care about the newline?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant