Overall upgrade of the package (#516)

* chore: convert tslint to eslint * chore: upgrade to react-native 0.72.5 and expo 49 * chore: clean app and fix linting errors * fix: test are failing without testEnvironment
xcarpentier · Oct 3, 2023 · f4207eb · f4207eb
1 parent e1f8a45
commit f4207eb
Show file tree

Hide file tree

Showing 16 changed files with 7,628 additions and 4,263 deletions.
diff --git a/.eslintignore b/.eslintignore
@@ -0,0 +1,47 @@
+.DS_Store
+
+# Logs
+logs
+*.log
+
+# Runtime data
+pids
+*.pid
+*.seed
+
+# Directory for instrumented libs generated by jscoverage/JSCover
+lib-cov
+
+# Coverage directory used by tools like istanbul
+coverage
+
+# Grunt intermediate storage (http://gruntjs.com/creating-plugins#storing-task-files)
+.grunt
+
+# node-waf configuration
+.lock-wscript
+
+# Compiled binary addons (http://nodejs.org/api/addons.html)
+build/Release
+
+# Dependency directory
+# https://www.npmjs.org/doc/misc/npm-faq.html#should-i-check-my-node_modules-folder-into-git
+/node_modules
+
+# Xcode
+*.xcuserstate
+examples/ios/swiper.xcodeproj/project.xcworkspace/
+examples/ios/swiper.xcodeproj/xcuserdata
+
+# IntelliJ
+.idea/
+
+# VSCode
+.vscode
+jsconfig.json
+.expo/
+lib/
+web-build/
+
+./eslintrc.js
+/scripts/
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -0,0 +1,276 @@
+/*
+👋 Hi! This file was autogenerated by tslint-to-eslint-config.
+https://github.com/typescript-eslint/tslint-to-eslint-config
+
+It represents the closest reasonable ESLint configuration to this
+project's original TSLint configuration.
+
+We recommend eventually switching this configuration to extend from
+the recommended rulesets in typescript-eslint. 
+https://github.com/typescript-eslint/tslint-to-eslint-config/blob/master/docs/FAQs.md
+
+Happy linting! 💖
+*/
+module.exports = {
+  env: {
+    browser: true,
+    es6: true,
+  },
+  extends: [
+    'plugin:@typescript-eslint/recommended',
+    'plugin:@typescript-eslint/recommended-requiring-type-checking',
+    'prettier',
+  ],
+  parser: '@typescript-eslint/parser',
+  parserOptions: {
+    project: true,
+    tsconfigRootDir: __dirname,
+    sourceType: 'module',
+  },
+  plugins: [
+    'eslint-plugin-import',
+    'eslint-plugin-jsdoc',
+    'eslint-plugin-prefer-arrow',
+    'eslint-plugin-react',
+    '@typescript-eslint',
+  ],
+  root: true,
+  ignorePatterns: ['.eslintrc.js', '*.test.tsx', '*.config.js'],
+  rules: {
+    '@typescript-eslint/unbound-method': 'off',
+    '@typescript-eslint/no-unsafe-assignment': 'off',
+    '@typescript-eslint/adjacent-overload-signatures': 'error',
+    '@typescript-eslint/array-type': [
+      'error',
+      {
+        default: 'array',
+      },
+    ],
+    '@typescript-eslint/ban-types': [
+      'error',
+      {
+        types: {
+          Object: {
+            message: 'Avoid using the `Object` type. Did you mean `object`?',
+          },
+          Function: {
+            message:
+              'Avoid using the `Function` type. Prefer a specific function type, like `() => void`.',
+          },
+          Boolean: {
+            message: 'Avoid using the `Boolean` type. Did you mean `boolean`?',
+          },
+          Number: {
+            message: 'Avoid using the `Number` type. Did you mean `number`?',
+          },
+          String: {
+            message: 'Avoid using the `String` type. Did you mean `string`?',
+          },
+          Symbol: {
+            message: 'Avoid using the `Symbol` type. Did you mean `symbol`?',
+          },
+        },
+      },
+    ],
+    '@typescript-eslint/consistent-type-assertions': 'error',
+    '@typescript-eslint/dot-notation': 'off',
+    '@typescript-eslint/explicit-function-return-type': 'off',
+    '@typescript-eslint/explicit-member-accessibility': [
+      'off',
+      {
+        accessibility: 'explicit',
+      },
+    ],
+    '@typescript-eslint/explicit-module-boundary-types': 'off',
+    '@typescript-eslint/indent': 'off',
+    '@typescript-eslint/member-delimiter-style': [
+      'off',
+      {
+        multiline: {
+          delimiter: 'none',
+          requireLast: true,
+        },
+        singleline: {
+          delimiter: 'semi',
+          requireLast: false,
+        },
+      },
+    ],
+    '@typescript-eslint/naming-convention': [
+      'off',
+      {
+        selector: 'variable',
+        format: ['camelCase', 'UPPER_CASE'],
+        leadingUnderscore: 'forbid',
+        trailingUnderscore: 'forbid',
+      },
+    ],
+    '@typescript-eslint/no-empty-function': 'off',
+    '@typescript-eslint/no-empty-interface': 'error',
+    '@typescript-eslint/no-explicit-any': 'off',
+    '@typescript-eslint/no-misused-new': 'error',
+    '@typescript-eslint/no-namespace': 'error',
+    '@typescript-eslint/no-parameter-properties': 'off',
+    '@typescript-eslint/no-shadow': [
+      'off',
+      {
+        hoist: 'all',
+      },
+    ],
+    '@typescript-eslint/no-unused-expressions': 'error',
+    '@typescript-eslint/no-use-before-define': 'off',
+    '@typescript-eslint/no-var-requires': 'off',
+    '@typescript-eslint/prefer-for-of': 'error',
+    '@typescript-eslint/prefer-function-type': 'error',
+    '@typescript-eslint/prefer-namespace-keyword': 'error',
+    '@typescript-eslint/quotes': 'off',
+    '@typescript-eslint/semi': ['off', null],
+    '@typescript-eslint/triple-slash-reference': [
+      'error',
+      {
+        path: 'always',
+        types: 'prefer-import',
+        lib: 'always',
+      },
+    ],
+    '@typescript-eslint/type-annotation-spacing': 'off',
+    '@typescript-eslint/typedef': 'off',
+    '@typescript-eslint/unified-signatures': 'error',
+    'arrow-parens': ['off', 'always'],
+    'brace-style': ['off', 'off'],
+    'comma-dangle': 'off',
+    complexity: 'off',
+    'constructor-super': 'error',
+    'dot-notation': 'off',
+    'eol-last': 'off',
+    eqeqeq: ['error', 'smart'],
+    'guard-for-in': 'error',
+    'id-denylist': 'off',
+    'id-match': 'off',
+    'import/order': [
+      'off',
+      {
+        alphabetize: {
+          caseInsensitive: true,
+          order: 'asc',
+        },
+        'newlines-between': 'ignore',
+        groups: [
+          ['builtin', 'external', 'internal', 'unknown', 'object', 'type'],
+          'parent',
+          ['sibling', 'index'],
+        ],
+        distinctGroup: false,
+        pathGroupsExcludedImportTypes: [],
+        pathGroups: [
+          {
+            pattern: './',
+            patternOptions: {
+              nocomment: true,
+              dot: true,
+            },
+            group: 'sibling',
+            position: 'before',
+          },
+          {
+            pattern: '.',
+            patternOptions: {
+              nocomment: true,
+              dot: true,
+            },
+            group: 'sibling',
+            position: 'before',
+          },
+          {
+            pattern: '..',
+            patternOptions: {
+              nocomment: true,
+              dot: true,
+            },
+            group: 'parent',
+            position: 'before',
+          },
+          {
+            pattern: '../',
+            patternOptions: {
+              nocomment: true,
+              dot: true,
+            },
+            group: 'parent',
+            position: 'before',
+          },
+        ],
+      },
+    ],
+    indent: 'off',
+    'jsdoc/check-alignment': 'error',
+    'jsdoc/check-indentation': 'error',
+    'linebreak-style': 'off',
+    'max-classes-per-file': ['error', 1],
+    'max-len': 'off',
+    'new-parens': 'off',
+    'newline-per-chained-call': 'off',
+    'no-bitwise': 'error',
+    'no-caller': 'error',
+    'no-cond-assign': 'error',
+    'no-console': 'off',
+    'no-debugger': 'error',
+    'no-empty': 'off',
+    'no-empty-function': 'off',
+    'no-eval': 'error',
+    'no-extra-semi': 'off',
+    'no-fallthrough': 'off',
+    'no-invalid-this': 'off',
+    'no-irregular-whitespace': 'off',
+    'no-multiple-empty-lines': 'off',
+    'no-new-wrappers': 'error',
+    'no-shadow': 'off',
+    'no-throw-literal': 'error',
+    'no-trailing-spaces': 'off',
+    'no-undef-init': 'error',
+    'no-underscore-dangle': 'off',
+    'no-unsafe-finally': 'error',
+    'no-unused-expressions': 'off',
+    'no-unused-labels': 'error',
+    'no-use-before-define': 'off',
+    'no-var': 'error',
+    'object-shorthand': 'error',
+    'one-var': ['off', 'never'],
+    'padded-blocks': [
+      'off',
+      {
+        blocks: 'never',
+      },
+      {
+        allowSingleLineBlocks: true,
+      },
+    ],
+    'prefer-arrow/prefer-arrow-functions': 'error',
+    'prefer-const': 'error',
+    'quote-props': 'off',
+    quotes: 'off',
+    radix: 'error',
+    'react/jsx-curly-spacing': 'off',
+    'react/jsx-equals-spacing': 'off',
+    'react/jsx-tag-spacing': [
+      'off',
+      {
+        afterOpening: 'allow',
+        closingSlash: 'allow',
+      },
+    ],
+    'react/jsx-wrap-multilines': 'off',
+    semi: 'off',
+    'space-before-function-paren': 'off',
+    'space-in-parens': ['off', 'never'],
+    'spaced-comment': [
+      'error',
+      'always',
+      {
+        markers: ['/'],
+      },
+    ],
+    'use-isnan': 'error',
+    'valid-typeof': 'off',
+  },
+}
diff --git a/App.tsx b/App.tsx
@@ -52,17 +52,15 @@ const Option = ({ value, onValueChange, title }: OptionProps) => (
   </Row>
 )
 
-export default function App() {
-  const [countryCode, setCountryCode] = useState<CountryCode | undefined>()
-  const [country, setCountry] = useState<Country>(null)
-  const [withCountryNameButton, setWithCountryNameButton] = useState<boolean>(
-    false,
-  )
+const App = () => {
+  const [countryCode, setCountryCode] = useState<CountryCode>('US')
+  const [country, setCountry] = useState<Country>()
+  const [withCountryNameButton, setWithCountryNameButton] =
+    useState<boolean>(false)
   const [withCurrencyButton, setWithCurrencyButton] = useState<boolean>(false)
   const [withFlagButton, setWithFlagButton] = useState<boolean>(true)
-  const [withCallingCodeButton, setWithCallingCodeButton] = useState<boolean>(
-    false,
-  )
+  const [withCallingCodeButton, setWithCallingCodeButton] =
+    useState<boolean>(false)
   const [withFlag, setWithFlag] = useState<boolean>(true)
   const [withEmoji, setWithEmoji] = useState<boolean>(true)
   const [withFilter, setWithFilter] = useState<boolean>(true)
@@ -72,7 +70,7 @@ export default function App() {
   const [withModal, setWithModal] = useState<boolean>(true)
   const [visible, setVisible] = useState<boolean>(false)
   const [dark, setDark] = useState<boolean>(false)
-  const [fontScaling, setFontScaling] = useState<boolean>(true)
+  const [allowFontScaling, setFontScaling] = useState<boolean>(true)
   const [disableNativeModal, setDisableNativeModal] = useState<boolean>(false)
   const onSelect = (country: Country) => {
     setCountryCode(country.cca2)
@@ -106,7 +104,7 @@ export default function App() {
         />
         <Option
           title='With font scaling'
-          value={fontScaling}
+          value={allowFontScaling}
           onValueChange={setFontScaling}
         />
         <Option
@@ -153,7 +151,7 @@ export default function App() {
         <CountryPicker
           theme={dark ? DARK_THEME : {}}
           {...{
-            allowFontScaling: fontScaling,
+            allowFontScaling,
             countryCode,
             withFilter,
             excludeCountries: ['FR'],
@@ -170,9 +168,7 @@ export default function App() {
             onSelect,
             disableNativeModal,
             preferredCountries: ['US', 'GB'],
-            modalProps: {
-              visible,
-            },
+            modalProps: { visible },
             onClose: () => setVisible(false),
             onOpen: () => setVisible(true),
           }}
@@ -189,3 +185,5 @@ export default function App() {
     </CountryModalProvider>
   )
 }
+
+export default App