Skip to content

Commit

Permalink
backend: Stop converting all "\" to "/" in command
Browse files Browse the repository at this point in the history
We tried removing that hack in
mesonbuild#737 but it had to be reverted
with no real explanation 8 years ago:
mesonbuild#773

Things changed since, we could be in a better world, let's try again.
  • Loading branch information
xclaesse committed Dec 20, 2023
1 parent 0c3e84b commit e85d67e
Showing 1 changed file with 0 additions and 19 deletions.
19 changes: 0 additions & 19 deletions mesonbuild/backend/backends.py
Original file line number Diff line number Diff line change
Expand Up @@ -1576,25 +1576,6 @@ def eval_custom_target_command(
# Substitute the rest of the template strings
values = mesonlib.get_filenames_templates_dict(inputs, outputs)
cmd = mesonlib.substitute_values(cmd, values)
# This should not be necessary but removing it breaks
# building GStreamer on Windows. The underlying issue
# is problems with quoting backslashes on Windows
# which is the seventh circle of hell. The downside is
# that this breaks custom targets whose command lines
# have backslashes. If you try to fix this be sure to
# check that it does not break GST.
#
# The bug causes file paths such as c:\foo to get escaped
# into c:\\foo.
#
# Unfortunately we have not been able to come up with an
# isolated test case for this so unless you manage to come up
# with one, the only way is to test the building with Gst's
# setup. Note this in your MR or ping us and we will get it
# fixed.
#
# https://github.com/mesonbuild/meson/pull/737
cmd = [i.replace('\\', '/') for i in cmd]
return inputs, outputs, cmd

def get_run_target_env(self, target: build.RunTarget) -> mesonlib.EnvironmentVariables:
Expand Down

0 comments on commit e85d67e

Please sign in to comment.