Improve LinstorSR.py to handle thick SR creation
#85
Conversation
drivers/LinstorSR.py
Outdated
| for attempt in range(3): | ||
| online_hosts = util.get_online_hosts(self.session) | ||
| if len(online_hosts) >= len(host_adresses): | ||
| util.SMlog("DEBUG: All hosts online") | ||
| break # Ok and proceed to create | ||
| else: | ||
| util.SMlog("DEBUG: Online host: {} ; Adresses: {}".format(online_hosts, host_adresses)) | ||
| time.sleep(15) # Sleep and retry |
There was a problem hiding this comment.
I think it's better to modify the logic of get_online_hosts instead (without using host metrics, just enabled flag I guess) and not try to add a sleep call during creation.
There was a problem hiding this comment.
Can we look for reason on why host metrics were used here? Or we can introduce get_enabled_hosts to be at par with semantics and use it while leaving get_online_hosts as is. Will go with your call.
There was a problem hiding this comment.
The function get_online_hosts predate the git history, it won't be easy to know why
There was a problem hiding this comment.
@rushikeshjadhav I agree with you, a new function is probably a good idea. This would avoid breaking the use of the current function in cleanup.py.
There was a problem hiding this comment.
By looking at code, online_hosts seems necessary to fetch hostname and its ip address. There is verification logic about Multiple hosts with same hostname.
Further it calls _prepare_sr_on_all_hosts with enabled=True which subsequently calls _prepare_sr that works if host is enabled. So checking for enabled may be redundant.
This might have to be verified with someone from xapi that if fetching ip address matters in cases of enabled vs online. We can switch to enabled if ip address and hostnames are available at this stage or have to revert to online and wait for it.
In some drivers e.g. Linstor, we need to ensure that hosts are enabeld before performing operations, hence this function is needed. Signed-off-by: Rushikesh Jadhav <[email protected]>
…as the metrics could take time. Thus, changed the mechanism to `get_enabled_hosts`. Signed-off-by: Rushikesh Jadhav <[email protected]>
rushikeshjadhav
force-pushed
the
3.2.3-8.3-online-hosts
branch
from
ea5a1e7 to
697676c
Compare
In some cases
thickSR creation may fail due toget_online_hostsas the metrics could take time. Thus, changed the mechanism toget_enabled_hosts.