-
Notifications
You must be signed in to change notification settings - Fork 109
UEFI vs BIOS warning in upgrade documentation and troubleshooting guide #405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yblatti
wants to merge
5
commits into
xcp-ng:master
Choose a base branch
from
yblatti:uefi-bios-warning-in-upgrade
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6c8cabf
upgrade.md : Warning on ISO boot mode for XenServer ugrade
yblatti 9c537cc
upgrade.md : Upgrade via installation ISO : redirect to "installation…
yblatti 4dfbb88
upgrade.md : Warning on ISO boot mode for ISO ugrade
yblatti e0f085a
installation-upgrade.md : Add a troubleshooting entry for upgrade not…
yblatti c44b1af
Apply suggestions from code review (@thomas-dkmt)
yblatti File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a trailing
\.But that's not the comment I wanted to make initially: mismatching firmware mode is not the only reason why the installer will not offer to upgrade in some cases.
For example, in some cases, the firstboot script in the previous installation never completed, which prevents the installer from detecting the existing installation.
@ydirson can likely tell more about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your feedback !
TBH, this is out of my league. Feel free to add any relevant information in this section. We could also change the title to a more specific one.
The new line was added for readability. Should I remove it ?