air gapped update #285
Open
air gapped update #285
+53
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glehmann
force-pushed
the
air-gapped-update
branch
from
827d442 to
cd61472
Compare
glehmann
force-pushed
the
air-gapped-update
branch
2 times, most recently
from
7e5b59e to
80cf940
Compare
glehmann
force-pushed
the
air-gapped-update
branch
3 times, most recently
from
69cc887 to
6383196
Compare
glehmann
force-pushed
the
air-gapped-update
branch
from
6383196 to
6adcc80
Compare
glehmann
force-pushed
the
air-gapped-update
branch
from
6adcc80 to
33db5b4
Compare
Signed-off-by: Gaëtan Lehmann <[email protected]>
glehmann
force-pushed
the
air-gapped-update
branch
from
33db5b4 to
b919018
Compare
rzr
reviewed
Nov 24, 2025
| def test_air_gapped_update(host: Host): | ||
| # get the required files and install the offline repositories | ||
| air_gapped_download( | ||
| 'https://raw.githubusercontent.com/xcp-ng/xcp/refs/heads/master/scripts/setup_offline_xcpng_repos', host |
There was a problem hiding this comment.
I would create a variable or env var the can override the location, using floating master as default
but I believe a pinned version would make the test more reproductible
rzr
reviewed
Nov 24, 2025
|
|
||
| def air_gapped_download(url: str, host: Host): | ||
| logging.debug(f"downloading {url}") | ||
| tmppath = f'/tmp/{os.path.basename(url)}' |
There was a problem hiding this comment.
would use secure tmp directory to avoid possible overlap
rzr
reviewed
Nov 24, 2025
| # Requirements: | ||
| # - a host running XCP-ng 8.3. | ||
| # - with no access to internet | ||
| # - TODO: a snapshot to restore the host to a state without the offline repositories, to integrate when #226 |
There was a problem hiding this comment.
This one #226 or something else ?
If yes then may TODO updated then
rzr
requested changes
Nov 24, 2025
rzr
left a comment
rzr
left a comment
There was a problem hiding this comment.
May TODO updated before merge, else LGTM few suggested added feel free to take into account
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test has to be run on an installed xcp-ng host for now.
It should be integrated with #226 code once its merged.