Enable side panels by default and increase edge trigger size#2
Open
xdonu2x wants to merge 12 commits into
Open
Enable side panels by default and increase edge trigger size#2xdonu2x wants to merge 12 commits into
xdonu2x wants to merge 12 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
leftEnabled/rightEnabledwerefalse) and the edge hover trigger was only 2px, causing users to miss the activation area.sidePanelsobject do not silently disable the feature.Description
leftEnabledandrightEnabledtotruein bothCommons/Settings.qmlandAssets/settings-default.json.triggerSizefrom2to8inCommons/Settings.qml,Assets/settings-default.json, and the runtime fallback inModules/MainScreen/SideWidgetPanel.qmlso edge-hover activation is easier.Modules/MainScreen/SideWidgetPanel.qml(new) which implements hover-reveal side panels, panel sizing, reveal/conceal timers, and loading of bar widgets for left/right sides.SideWidgetPanelinstances intoModules/MainScreen/MainScreen.qmland extend themaskregions to include panel bodies and trigger zones so pointer and click-to-close behavior remain correct.Testing
Assets/settings-default.jsonparses successfully withpython3 -c "import json; json.load(open('Assets/settings-default.json'))"(succeeded).rg/nlto confirm defaults and runtime fallbacks are present inCommons/Settings.qml,Assets/settings-default.json, andModules/MainScreen/SideWidgetPanel.qml(succeeded).Enable side panels by default and widen edge trigger).Codex Task