fix: power user popup chart errors and model list overflow#203
Merged
Conversation
Contributor
|
Tagging Rob Bos (@rajbos) for notifications |
Rob Bos (rajbos)
requested a deployment
to
github-pages
GitHub Actions
Waiting
Rob Bos (rajbos)
requested a deployment
to
github-pages
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fix chart crash when disabling a model in the legend
Clicking a model name in the Power User Breakdown chart legend previously set visibleBars to the model name, which broke the tooltip (looked up model name in a config that only had compliant/exceeding keys, causing 'Cannot read properties of undefined (reading color)') and didn't actually hide the model.
Fix: Added hiddenPowerUserModelNames state to track hidden models. getVisiblePowerUserModels() filters them out. Legend click handler properly distinguishes model toggles from compliance toggles. Tooltip rebuilt to use inline color resolution. Empty state shown when all bars are hidden. Dimmed visual for hidden legend items.
Fix model list overflow
The Requests per Model table overflowed the viewport with no horizontal scroll. Added overflow-x-auto, text truncation on model names, and width constraints.
Fix width/height -1 chart error
Added overflow-hidden and min-w-0 to chart wrappers to prevent transient negative dimension measurements during Sheet slide-in animation.