Move SHA1 and RC4 functions from eeprom specific file to utils #1660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mborgerson
reviewed
Jun 12, 2024
util/sha1_rc4.c
Outdated
| @@ -0,0 +1,168 @@ | |||
| /* | |||
There was a problem hiding this comment.
Let's split these out to separate files, one for SHA1 and another for RC4
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #1659, instead of pulling in another RC4/SHA1 implementation use the one already provided in the EEPROM generation code.
To do this it needs to be moved to a more accessible location.
To ensure I didnt break anything I generated an eeprom with xemu and loaded it up with https://github.com/Ernegien/XboxEepromEditor and made sure the hashes matched up