Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts/tracetool: Fix SyntaxWarning invalid escape sequence #1737

Closed
wants to merge 0 commits into from

Conversation

sertonix
Copy link

@sertonix sertonix commented Aug 6, 2024

No description provided.

Copy link
Contributor

@abaire abaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python changes lgtm.

The pci.c change should probably be upstreamed to qemu instead of patched here to minimize complexity of future qemu updates.

@sertonix
Copy link
Author

sertonix commented Apr 7, 2025

It looks like the usage of basename has been removed from the code since creating this MR. I dropped the pci.c change now since it isn't needed anymore.

Ref 5456b18 7e63b31 213ae3f

@sertonix sertonix changed the title Minor build fixes / compatibility scripts/tracetool: Fix SyntaxWarning invalid escape sequence Apr 7, 2025
@mborgerson mborgerson closed this Apr 7, 2025
@mborgerson
Copy link
Member

Thanks for the patch. It looks like this was fixed upstream a while back. I rebased this PR and GitHub auto-closed it because the diff was eliminated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants