Fix material color source ambient and emissive #2083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Emissive color is still slightly off, but it's much closer to correct than before. Will keep in draft for a bit to see if I can figure out why, but it'd be interesting to test this against games that have issues with emissive textures. |
|
Might fix Constantine lighting issues #1201 |
abaire
force-pushed
the
fix_material_color_source_ambient_and_emissive
branch
from
2419306 to
d70d2a0
Compare
abaire
force-pushed
the
fix_material_color_source_ambient_and_emissive
branch
from
d70d2a0 to
4ec7cce
Compare
|
Fixed the delta in emissive handling, should be ready for review now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes lighting in cases where ambient and/or emissive colors are taken from vertex colors rather than the material.
Tests
PR diff results