feat(chat): sync staged composer images and files with the draft - #483
Open
Adam-Dalloul wants to merge 3 commits into
Open
feat(chat): sync staged composer images and files with the draft#483Adam-Dalloul wants to merge 3 commits into
Adam-Dalloul wants to merge 3 commits into
Conversation
Adam-Dalloul
force-pushed
the
feat/composer-draft-attachments
branch
from
August 16, 2026 17:03
46a1110 to
698050f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge order
#479first (text-only draft sync)#483)#6pairs with#479#7stacks on iOS#6and pairs with this PRThis branch already contains
#479. Merge#479first so this reviews as the attachment-ref delta.#479syncs the typed text only. An image or file attached on desktop stayed on that device, so the phone sent text without it (and the other way around).This persists attachment refs, not bytes:
/upload_attachmentor a localstage_composer_attachment). The other device hydrates the thumbnail via jail-onlyread_upload_attachment.file://links. The host agent can already read those paths. The phone shows a chip and sendsresource_link.Old clients that omit
attachmentsdo not wipe the other side.[]is an explicit clear. First GET must finish before a new client sends the field.256 KiB text cap is unchanged. Attachment metadata is 16 items, jail-checked, no raw bytes in SQLite.
No secrets. One extra concern on top of
#479.