fix device selection for mps #65
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah I see there is already a pending PR with this fix: #41 |
|
o7 xlr8! Try the following. toml line 18:
Then add before or behind the other .source:
with the respective line breaks of course. HTH |
|
oh, thanks! and that won't break the cuda installs separately? |
|
You should probably submit that fix as a separate PR! |
|
I honestly still have to test it on ubuntu+4090 but I am still stuck in the jax-metal PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing the kvcache to end up on cpu on mps.
This doesn't entirely fix mac: the pyproject.toml tries to force a cuda version of torch, but I don't know the pyproject format well enough to know how to fix that cleanly.