add missing validator for stereo switch #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a Pydantic post-validation hook to the SwitchStereo stage model so that the position field’s maximum value is dynamically restricted based on the number of inputs.
- Introduces
set_max_outputsvalidator to compute and append aLeconstraint forposition - Calculates
max_valfromself.placement.input - Returns
selfto allow for chaining
Comments suppressed due to low confidence (1)
python/audio_dsp/models/signal_chain.py:196
- Add or update tests to verify that valid and invalid
positionvalues are correctly accepted or rejected based on the number of inputs.
@model_validator(mode="after")
xhuw
reviewed
Jul 11, 2025
| """Set the maximum number os switch positions.""" | ||
| max_val = len(self.placement.input) | ||
| type(self.parameters).model_fields["position"].metadata.append( | ||
| annotated_types.Le(max_val - 1) |
Collaborator
There was a problem hiding this comment.
This presumably only works if all the switches in your pipeline have the same number of inputs
Collaborator
Author
There was a problem hiding this comment.
I'm not sure actually, I'll investigate
LeslieXMOS
reviewed
Nov 26, 2025
Collaborator
Author
|
Untested if switches with different number of inputs need a different validator, but merging anyway to get a somewhat working validator |
Allan-xmos
force-pushed
the
feature/fix_stereo_switch
branch
2 times, most recently
from
5982f5a to
f16daba
Compare
Allan-xmos
force-pushed
the
feature/fix_stereo_switch
branch
from
f16daba to
2c153e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.