Skip to content

Conversation

@xalbertoisorna
Copy link
Contributor

@xalbertoisorna xalbertoisorna commented Oct 25, 2024

added multiple payload support for spi_test

@xalbertoisorna xalbertoisorna requested a review from xhuw October 29, 2024 10:15
@xalbertoisorna xalbertoisorna changed the title Feature/spi test Added flexible payload to SPI example Oct 29, 2024
}

printf("started\n");
printf("using payload of size %d\n", PAYLOAD_LEN);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not very flexible if its hardcoded? or am I missing something

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is configurable at compile time, before was hardcoded to be 1. We do not expect runtime variable length because it can overcomplicate the example.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps some extra docs to make it clear whats going on, otherwise this work doesn't add much value. The reader will need to know that this feature exists in order for it to be of any use

Copy link
Contributor Author

@xalbertoisorna xalbertoisorna Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The benefit is that to test a transfer of Xbytes for example (for instance to compare timings with the one on fwk_rtos) is much easier to have it as a define here.

The default value is back to 1 to match the rest of the examples.

@xalbertoisorna xalbertoisorna requested a review from xhuw October 29, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants