-
Notifications
You must be signed in to change notification settings - Fork 19
Added flexible payload to SPI example #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
| } | ||
|
|
||
| printf("started\n"); | ||
| printf("using payload of size %d\n", PAYLOAD_LEN); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not very flexible if its hardcoded? or am I missing something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is configurable at compile time, before was hardcoded to be 1. We do not expect runtime variable length because it can overcomplicate the example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps some extra docs to make it clear whats going on, otherwise this work doesn't add much value. The reader will need to know that this feature exists in order for it to be of any use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The benefit is that to test a transfer of Xbytes for example (for instance to compare timings with the one on fwk_rtos) is much easier to have it as a define here.
The default value is back to 1 to match the rest of the examples.
added multiple payload support for spi_test