Fix the infinite loop in mul_boggle #206
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function mul_boggle will find the closest output scale and bias, and vlashr_shr parameters such that it will not overflow in vpu calculation.
The current code will have an infinite loop when the required vlashr_shr is smaller than vdepth8_shr or (vlsat_shr + vlmul_shr + vdepth8_shr).
As vdepth8_shr and vlsat_shr are unsigned variable, it will underflow when vlashr_shr is too small.
This cause pow(2, y) in L51 and L63 can never output value smaller than 1, thus the loop never ends.
This pull request updated vdepth8_shr and vlsat_shr to signed variable, prevent underflow in the operation.