Skip to content

Dual USB #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ed-xmos wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Dual USB #386

ed-xmos wants to merge 6 commits into from
+1,060 −90

Conversation

@ed-xmos
Copy link
Contributor

@ed-xmos ed-xmos commented Dec 11, 2023

@ed-xmos ed-xmos requested a review from xross as a code owner December 11, 2023 10:18
@ed-xmos
Copy link
Contributor Author

ed-xmos commented Dec 11, 2023

@xross I wanted to make a PR so I can run it through the regression and get your thoughts on it.
This is the approach with the least impact I could find. I have tested it on AI with dual devices, AI with single device and X200 with single device.
Very happy to take you through other approaches and their pros/cons.
I like this approach as it is only a minor version bump due to 100% backwards compatibility. There are more thorough ways to do this (fully reentrant etc.) but I thinkthis is the quickest route to a customer solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xross xross Awaiting requested review from xross xross is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ed-xmos